Skip to content

Update React on Rails to 17.2.1.rc.0 - #34

Merged
justin808 merged 1 commit into
mainfrom
justin808-codex/ad-hoc-fleet-v17-2-1-rc-0-upgrade
Oct 27, 2026
Merged

justin808 merged 1 commit into
mainfrom
justin808-codex/ad-hoc-fleet-v17-2-1-rc-0-upgrade

Conversation

@justin808

@justin808 justin808 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

🤖 Codex · OpenAI · gpt-6.1-sol (configured) · medium

Served model unavailable in saved Codex logs.

Recommendation: Merge · Code Walkthrough · Code Review · Checkpoint

Checkpoint on verification: Adequate.

Summary

The migration example now uses matching React on Rails 17.2.1 release-candidate packages.

Intent

Why: The example still used 17.2.0.

Safe because: Local builds, tests, SSR and interaction checks passed.

Review effort: 2 of 5, easy: skim the diff. Floor 2: changes code or configuration (Gemfile).

Scope: Update both product pins and regenerate their locks. (4 files, +8 / −8 lines)

Files: Other 4

Other:

  • Gemfile
  • Gemfile.lock
  • package.json
  • yarn.lock

Verification

Validation passed; local review completed at 16b349e (evidence).

Evidence and limitations

Validation and review: validate passed (exit 0); local review by anthropic/claude, openai/codex (attestation) at 16b349e.

  • bundle install and yarn install --frozen-lockfile --non-interactive passed.
  • .agents/bin/validate passed: production build, 7 tests and 37 assertions.
  • Browser smoke on /, /posts/0, /hello_world passed SSR, hydration and typing interaction without errors.

Not verified: No deployed review app is configured; localhost verification covers the claimed runtime behavior.

Review history and scope

Local Claude and Codex reviews and the independent exact-head audit completed with no unresolved findings. Hosted reviews and all checks passed. Fresh build/tests and browser SSR/hydration/typing checks passed before the authorized automatic merge. Private reports, recovery metadata and usage identifiers are withheld.

Risk and rollback

This example intentionally adopts a release candidate. Regressions could affect SSR or hydration. Reverting restores both pins and locks to 17.2.0. No data migration or external deployment is part of this change.

Shaka metrics

Estimated token costs: $0.18

Details
Usage and cost · $0.18 estimated
Report USD Codex credits Input Cached input Output Reasoning Cache writes
claude‑opus‑5‑5 review $0.14 — 6 45.6K 2.3K 672 10.1K
gpt‑6.1‑sol review $0.05 1.19 78.9K 63.7K 1.1K 12 0
Total $0.18 1.19+

— not reported; + some usage not reported, so the amount is a minimum.

Understand the columns and accounting rules.

How each report was measured and priced

claude‑opus‑5‑5 review

Rate card: installed Shaka.

Claude CLI recorded estimated USD for an independent call; not an invoice.

Local adversarial reviewer usage: included below. External reviewer/tool-model usage: UNKNOWN.

Native usage is PARTIAL. Scope: all turns in selected sources.

gpt‑6.1‑sol review

Rate card: installed Shaka.

Standard Codex credit and OpenAI API-equivalent rates, verified 2026-09-29.

Sources: Codex credit rates, GPT-6.1 Sol, and prompt-cache accounting.

Local adversarial reviewer usage: included below. External reviewer/tool-model usage: UNKNOWN.

Native usage is PARTIAL. Scope: all turns in selected sources.

Native usage identifiers are withheld under publication privacy requirements.

Timings · 10m between checkpoints · 31m waiting on a person in 3 waits

Totals: 10m between checkpoints · 31m waiting on a person in 3 waits

Stretch From To Time
Before the pull request 2026-10-27 01:06 2026-10-27 01:08 (opened) 1m
Between checkpoints 2026-10-27 01:08 2026-10-27 01:15 6m
Waiting on a person: merge approval 2026-10-27 01:15 2026-10-27 01:42 (resumed) 26m
Between checkpoints 2026-10-27 01:42 2026-10-27 01:43 <1m
Waiting on a person: resume 2026-10-27 01:43 2026-10-27 01:44 (resumed) 1m
Between checkpoints 2026-10-27 01:44 2026-10-27 01:45 1m
Waiting on a person: resume 2026-10-27 01:45 2026-10-27 01:49 (merged) 3m

Times are UTC wall-clock time. A wait runs from when an attention label goes on until it comes off or the pull request merges or closes.

Time before first recorded validation: unavailable; task start was not recorded.

Measured steps: Validation 49s (2 runs) · Local review 1m 7s (2 runs) · Product checkpoint 20s (1 run)

Step Started Time Result Model Machine
Validation: validate 2026-10-27 01:05 22s passed — m5
Local review 2026-10-27 01:07 31s completed anthropic m5
Local review 2026-10-27 01:07 36s completed openai m5
Product checkpoint 2026-10-27 01:12 20s completed openai · gpt-6.1-sol · medium m5
Validation: validate 2026-10-27 01:47 27s passed — m5

Each measured step is a helper run recorded on the machine that ran it. A step logged on a machine that never updated this description is missing, so the totals can be partial. A step can overlap the stretches above.

Understand the timings.

Execution details
Field Value
Task source description
Shaka skill version 8a71c66
Recommended model / effort GPT-6 / high
Active model / effort gpt-6.1-sol / medium
Shaka settings used

Recorded checks match this PR’s current commit.

Only the listed runs are covered. Selecting settings does not show that a check ran.

Current settings: Repository settings at 51cbb2a; Shaka 0.1.0.pre.1 (installed revision)

Step Settings source Run details
Validation Repository settings at 51cbb2a validate: 25s on m5 (Apple M5 Max, 18 cores, 128 GB RAM, 24 GB free, load 117→124)
Review Repository settings at 51cbb2a anthropic/claude: 29s
Review Repository settings at 51cbb2a openai/codex: 33s
Skills used
Skill Source Revision Phase Contribution Evidence Corroboration
run-fleet-validation shakacode/react_on_rails f16392f50f23eb9f5176aaa9c1868f987ec5f4e9 intake Verify candidate barriers and retain separate supplemental evidence Corroborated skill read and live marker reads
pstack-principle-prove-it-works cursor/plugins UNKNOWN verification Verify actual SSR and interactive browser behavior Corroborated skill read

Agent-reported use is the agent’s account. The agent selects Corroborated when a record confirms invocation or loading. Shaka does not check that record or instruction compliance. Completeness is not verified.

PR prepared with Shaka.

Summary by CodeRabbit

  • Chores
    • Updated React on Rails to version 17.2.1 release candidate.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9b4fd2e9-2195-4feb-b9f4-ce209a4f1f66
Commits

Reviewing files that changed from the base of the PR and between 51cbb2a and 16b349e.

Files ignored due to path filters: 2
  • Gemfile.lock is excluded by !**/*.lock
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 2
  • Gemfile
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Gemfile and package.json now specify React on Rails version 17.2.1 release-candidate builds instead of version 17.2.0.

Changes

Dependency version update

Layer / File(s) Summary
Update dependency versions
Gemfile, package.json
The Ruby and JavaScript manifests now specify version 17.2.1 release-candidate builds.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

  • shakacode/react_on_rails#5245 tracks validation of the same release candidate, including migration examples and demo applications. This change updates the example’s dependency versions to that release candidate.
Merge Risk: Minimal · up to 16b34

The dependency update is mergeable with normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the dependency update in both Gemfile and package.json.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Oct 27, 2026

Copy link
Copy Markdown

Review: the bump is consistent. Gem 17.2.1.rc.0 and npm 17.2.1-rc.0 are the matching RubyGems and semver spellings of the same prerelease, and Gemfile, Gemfile.lock, package.json and yarn.lock all agree. I found no code, security or performance issues in the diff, and I did not run CI or the app.

Notes:

  • This moves the example app onto a release candidate. That's fine if the aim is to validate the RC, but it shouldn't be merged as the app's stable version unless that's intended.
  • Per AGENTS.md, dependency bumps are maintainer-gated, so this needs maintainer sign-off.
  • Before merging, confirm the full gh pr checks list is green. That should cover the Rails and JS test jobs, plus the webpack/Shakapacker build, since the gem and npm package must stay in lockstep.
  • I couldn't verify the yarn.lock integrity hash or the registry tarball offline. A yarn install --frozen-lockfile in CI will confirm it.

@justin808

justin808 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member Author

🤖 AGENT · OpenAI · gpt-6.1-sol · medium

Local Adversarial Review

Reviewed revision: 16b349e

Outcome: No open findings; closed and optional findings are in history.

Coverage: anthropic/claude: Supplied diff only; unchanged source and test execution are unavailable to this reviewer. · openai/codex: Read-only source lookup permitted; actual inspection coverage is UNKNOWN. Test execution is prohibited.

Usage and attribution in the PR description.

Reviewed commits:

Commit Findings
16b349e anthropic/claude: 1 (1 dismissed) · openai/codex: 0
Findings, assessments, and execution metadata

Finding details

  • F1 risk: Stable-to-RC adoption requires maintainer authorization — Dismissed — The maintainer explicitly authorized this exact v17.2.1.rc.0 upgrade. Ask remains required and no merge or auto-merge is authorized. Bundler conservatively regenerated the lock; Yarn regenerated and then passed frozen installation. Local full validation passed (7 tests, 37 assertions), and a real browser passed SSR on all three routes plus hydration and typing interaction with zero errors. · Reported by: anthropic/claude · last recorded at 16b349e

Execution metadata

Round Commit Reviewer Findings Tokens Cost
1 16b349e anthropic/claude
model claude-opus-5-5
effort UNKNOWN
1 (1 dismissed) 6 input
45,565 cached input
10,096 cache writes
2,298 output
672 reasoning output
$0.14 estimated
2 16b349e openai/codex
model UNKNOWN
effort UNKNOWN
0 78,885 input
63,744 cached input
0 cache writes
1,087 output
12 reasoning output
$0.05 estimated

Prompt: Shaka default · criteria 51cbb2a

Commit 16b349e · anthropic/claude, openai/codex · 1 finding

Commit: 16b349e Keep the migration example aligned with the 17.2.1 release candidate

Review coverage:

Coverage excerpts may be incomplete or misidentified; inspect the original reports.

  • anthropic/claude: Supplied diff only; unchanged source and test execution are unavailable to this reviewer.

Unverified report excerpt · anthropic/claude:

UNKNOWN; inspect the original report for complete coverage limits.
  • openai/codex: Read-only source lookup permitted; actual inspection coverage is UNKNOWN. Test execution is prohibited.

Unverified report excerpt · openai/codex:

UNKNOWN; inspect the original report for complete coverage limits.
Round 1 · 16b349e · anthropic/claude · effort UNKNOWN · 1 finding

Owner-authored technical summary of the completed private Claude review. The full report remains private.

Coverage: supplied four-file dependency diff and trusted default-branch AGENTS.md. The reviewer did not run tests or inspect unchanged source.

Finding 1 (risk): moving stable pins to an RC requires maintainer authorization and Ask merge handling. Disposition: dismissed as a blocker because the maintainer explicitly authorized this exact RC upgrade; merge remains Ask.

The owner separately verified regenerated locks, installation, production build, 7 Rails tests with 37 assertions, SSR on all three routes, hydration and typing interaction with no browser errors.

REVIEWED 16b349e BY anthropic/claude EFFORT UNKNOWN FINDINGS 1

Collated as: #1 → F1

Round 2 · 16b349e · openai/codex · effort UNKNOWN · 0 findings

Owner-authored technical summary of the completed private Codex review. The full report remains private.

Coverage: complete dependency diff, trusted default-branch AGENTS.md, and read-only inspection of relevant configuration and rendering tests. The reviewer ran git diff --check and did not execute candidate code.

No findings. Product pins and generated locks consistently select the candidate. Runtime verification was performed separately by the task owner.

REVIEWED 16b349e BY openai/codex EFFORT UNKNOWN FINDINGS 0

REVIEWED 16b349e BY openai/codex EFFORT UNKNOWN FINDINGS 0

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issue was established.

Summary

Updates React on Rails from 17.2.0 to the 17.2.1 release candidate.

  • Rails and JavaScript now use React on Rails 17.2.1 release candidates.

Reviews (1) · Last reviewed commit: "Keep the migration example aligned with ..." · Reviewed by Greptile

@justin808 justin808 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Codex · OpenAI · gpt-6.1-sol (configured) · medium

Served model unavailable in saved Codex logs.

Code Walkthrough

The migration example now runs the 17.2.1 release candidate.

Change and evidence

Ruby and JavaScript pins match. Bundler and Yarn locks contain only the product update. Shakapacker stays at 10.3.2. Production build, seven tests and browser SSR/hydration/typing passed. Reverting restores 17.2.0. Proceed: the change remains appropriately scoped. Hosted claude-review and Greptile Review passed; no actionable findings.

Walkthrough for commit 16b349e. This is a COMMENT, not an approval.

Comment thread Gemfile Resolved
@justin808

Copy link
Copy Markdown
Member Author

🤖 Codex · OpenAI · gpt-6.1-sol (configured) · medium

Checkpoint for 16b349e

Recommendation: Merge

The minimal paired upgrade passed local runtime verification and all hosted checks; reviews found no remaining defects.

Reviewer verdict: Proceed, no unresolved concerns.

Verification: Adequate.

  • Weakest claim: Runtime compatibility beyond the three exercised routes remains unproven.
  • Next check: Repeat the reported smoke checks from a clean installation.
Supporting analysis and execution details

Reviewer summary: Maintainers can validate the matching Ruby and JavaScript RC packages. Local runtime checks passed; deployed behavior remains untested.

The four changed files match the planned paired version upgrade and lock regeneration, with no added abstractions or configuration.

Reported installs, build, tests, SSR, hydration, and interaction checks cover the intended local validation. No repair churn suggests an approach problem.

Alternative considered: Keeping 17.2.0 would avoid the upgrade but would not validate the requested RC.

observed model: UNKNOWN; configured model: gpt-6.1-sol · recorded effort: medium · prompt: Shaka default

Native usage (openai · gpt-6.1-sol · UNKNOWN · medium), 1 response: 17,285 input, 12,288 cached input, 0 cache writes, 383 output, 151 reasoning output, 17,668 total.

Ruby checked this report's format and commit; the reviewer judged value, not correctness. Required checks, reviews, and merge authority still apply.

Squash commit message

Squash commit message for 16b349e. Paste the title and the body into GitHub's squash merge boxes.

Update React on Rails to 17.2.1.rc.0 (#34)
Keep the OSS migration example current with the release candidate. Pin
the Ruby and JavaScript packages to matching candidate versions and
regenerate both locks without unrelated upgrades.

@justin808 justin808 added awaiting-merge-approval Ready under Ask: merge this commit or approve it so the agent merges awaiting-resume Paused with nothing to wake the agent; resume from WIP Details and removed awaiting-merge-approval Ready under Ask: merge this commit or approve it so the agent merges awaiting-resume Paused with nothing to wake the agent; resume from WIP Details labels Oct 27, 2026
@justin808
justin808 merged commit a2f0ec0 into main Oct 27, 2026
7 checks passed
@justin808 justin808 removed the awaiting-resume Paused with nothing to wake the agent; resume from WIP Details label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant