Skip to content

Bump the all-dependencies group across 1 directory with 30 updates #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

Bump the all-dependencies group across 1 directory with 30 updates #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ gem "coffee-rails"

# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem "jbuilder"
gem "redis", "~> 5.0"
gem "redis", "~> 6.0"

# bundle exec rake doc:rails generates the API under doc/api.
gem "sdoc", group: :doc
Expand Down Expand Up @@ -71,10 +71,10 @@ group :development, :test do

################################################################################
# Linters and Security
gem "rubocop", "1.69", require: false
gem "rubocop-performance", "1.23.1", require: false
gem "rubocop-rails", "2.29.1", require: false
gem "rubocop-rspec", "3.4.0", require: false
gem "rubocop", "1.91.0", require: false

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rename the boolean helper for the enabled predicate cop

With AllCops.NewCops: enable, RuboCop 1.91 enables Naming/PredicateMethod, which was added after 1.69 and requires boolean-returning methods to end in ? (RuboCop documentation). lib/tasks/linters.rake:14-19 defines to_bool with exclusively boolean return paths, so the Lint CI's bundle exec rake lint will report this method and remain red; rename it and its call site or explicitly configure the cop.

AGENTS.md reference: AGENTS.md:L18-L19

Useful? React with 👍 / 👎.

gem "rubocop-performance", "1.27.0", require: false
gem "rubocop-rails", "2.38.0", require: false

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve the newly enabled Rails status cop

With AllCops.NewCops: enable, upgrading rubocop-rails to 2.38 activates Rails/HttpStatusNameConsistency, added in 2.34. The lint job will therefore flag both existing :unprocessable_entity usages in app/controllers/comments_controller.rb:42 and :56, causing bundle exec rake lint to fail on every run. Migrate those statuses to :unprocessable_content or explicitly configure the new cop as part of this upgrade.

AGENTS.md reference: AGENTS.md:L18-L19

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update response parsing for the expanded Rails cop

With AllCops.NewCops: enable, rubocop-rails 2.35 expanded Rails/ResponseParsedBody to flag Nokogiri::HTML(response.body) (cop documentation); spec/requests/server_render_check_spec.rb still uses that form on lines 8 and 23, so the repository's RuboCop check fails after this upgrade. Replace both calls with response.parsed_body or explicitly exclude them.

AGENTS.md reference: AGENTS.md:L18-L19

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the newly detected strong parameter access

The upgraded Rails/StrongParametersExpect now detects parameters passed to raising finder methods such as Model.find(params[:id]) (cop documentation). CommentsController#set_comment still calls Comment.find(params[:id]) on line 110, so the configured RuboCop run now reports another offense; use params.expect(:id) there or configure the cop intentionally.

AGENTS.md reference: AGENTS.md:L18-L19

Useful? React with 👍 / 👎.

gem "rubocop-rspec", "3.10.2", require: false

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove or allow the RSpec helper output

With AllCops.NewCops: enable, rubocop-rspec 3.10.2 enables the pending RSpec/Output cop introduced in 3.9, which checks all files under spec/**/* for calls such as puts (RuboCop RSpec documentation). The three puts calls in spec/rails_helper.rb:81-83 are therefore offenses, so the Lint CI still fails even after the previously reported Rails status offenses are fixed; remove those messages or configure an intentional exclusion.

AGENTS.md reference: AGENTS.md:L18-L19

Useful? React with 👍 / 👎.

# Critical that require: false be set! https://github.com/brigade/scss-lint/issues/278
gem "scss_lint", require: false

Expand All @@ -97,12 +97,12 @@ end
group :test do
gem "capybara"
gem "capybara-screenshot"
gem "coveralls_reborn", "~> 0.25.0", require: false
gem "coveralls_reborn", "~> 1.0.0", require: false
gem "database_cleaner"
gem "generator_spec"
gem "launchy"
gem "rails_best_practices"
gem "rspec-rails", "~> 6.0.0"
gem "rspec-rails", "~> 8.0.4"

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rename the fixture path setting for RSpec Rails 8

RSpec Rails 8 replaces the fixture_path configuration setting with fixture_paths (8.0.4 configuration), but spec/rails_helper.rb:49 still calls config.fixture_path = .... Consequently every RSpec invocation raises NoMethodError while loading the helper, before any examples run; update that call to assign an array to config.fixture_paths as part of this major-version upgrade.

Useful? React with 👍 / 👎.

gem "selenium-webdriver", "~> 4"
end

Expand Down
Loading
Loading