Repository navigation
Bump React on Rails packages to 17.2.0 rc.1 - #853
Conversation
Pin the react_on_rails_pro gem to 17.2.0.rc.1 and the react-on-rails-pro and react-on-rails-pro-node-renderer npm packages to 17.2.0-rc.1. The core react_on_rails gem and react-on-rails package move with them through the lockfiles. React, ReactDOM, and react-on-rails-rsc are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
No description provided. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe Gemfile and package.json now specify React on Rails Pro version 17.2.0.rc.1, replacing version 17.2.0.rc.0. ChangesReact on Rails Pro dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The dependency declarations and lockfiles are aligned, so this update presents no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed: this is a clean, consistent bump of Notes:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
+review-app-deploy |
|
No description provided. |
Local Adversarial ReviewReviewed revision: Outcome: No open findings; closed and optional findings are in history. Coverage: anthropic/claude: Supplied diff only; unchanged source and test execution are unavailable to this reviewer. Usage and attribution in the PR description. Review evidence and historyCommit: Finding detailsReview coverage: Coverage excerpts may be incomplete or misidentified; inspect the original reports.
Unverified report excerpt · anthropic/claude: - **Inspected:** only the supplied diff, covering `Gemfile`, `Gemfile.lock`, `package.json` and `yarn.lock`. - **Not inspected:** the checkout itself. The file tools are confined to the session's temp directory, so every read of the worktree path was refused, and Git is unavailable. - **Tests run:** none. No `bundle exec rspec`, `bundle exec rubocop` or install was run, and candidate code was not executed. - **Missing context:** - Whether any file outside the diff still restates `17.2.0.rc.0` / `17.2.0-rc.0` (README, docs, Dockerfile, `.controlplane/`, CI workflows, initializers, a second lockfile such as `pnpm-lock.yaml`). - Whether the `resolved` hashes and `integrity` values in `yarn.lock` match what the npm registry publishes for rc.1; this needs network access. - The upstream changelog for rc.0 → rc.1, so behaviour changes in the gem or node renderer are unassessed. - Whether `Gemfile.lock` has a `CHECKSUMS` section that needed updating; none appears in the hunks shown. Execution metadata
Round 1 · 7f9a8ab · anthropic/claude · effort UNKNOWN · 0 findingsRepository criteria: supplied — Coverage
Findingsno findings Observations (not classed, not counted):
REVIEWED 7f9a8ab BY anthropic/claude EFFORT UNKNOWN FINDINGS 0 REVIEWED 7f9a8ab BY anthropic/claude EFFORT UNKNOWN FINDINGS 0 |
🎉 Deploy Complete!Open Review AppDeployment successful for PR #853, commit 7f9a8ab 🎮 Control Plane Console |
 |
justin808
left a comment
justin808
left a comment
There was a problem hiding this comment.
🤖 Claude Code · Anthropic · claude-opus-5-5 · medium
Code Walkthrough
The app installs React on Rails 17.2.0 rc.1 in place of rc.0, with no application code changed.
Ruby
The Gemfile pin moves react_on_rails_pro to 17.2.0.rc.1. The Pro gem requires the matching core gem exactly, so the lockfile moves react_on_rails with it. No other gem version changes; a conservative bundle update had also moved two unrelated gems, and those were reverted.
JavaScript
The Pro package pin and the Node renderer pin move to 17.2.0-rc.1. react-on-rails-pro depends on the same core version, so yarn.lock moves react-on-rails too. React, ReactDOM, react-server-dom-webpack 19.2.8 and react-on-rails-rsc 19.3.0 stay as they were, and rc.1 still accepts that RSC version as a peer.
Validation, risk, and rollback
Frozen installs and the full local CI script pass on this commit. Hosted checks pass too: Rspec CI, JS CI, Lint CI, and the required smoke / Demo fleet smoke. The claude-review and Greptile Review gates completed with no actionable findings.
Server rendering, the RSC page, its toggle, Refresh, the simulated error, and Retry work locally and on the review app. The risk is limited to behavior changes inside the release candidate. Reverting this commit returns the app to rc.0.
Walkthrough for commit 7f9a8ab35fb519423a85a30b4d26adc7e901509c. This is a COMMENT, not an approval.
|
🤖 Codex · OpenAI · gpt-6.1-sol (configured) · medium Post-implementation validationRecommendation: Proceed The change gives release maintainers evidence that the published rc.1 packages work together in the existing Pro and RSC tutorial, while keeping the reference app reproducibly pinned to that candidate. Its one-commit, four-file scope matches the requested outcome and adds no architectural burden. The reported validation supports this app’s release gate; it does not establish compatibility across every consumer application. Next action (task owner): Merge this PR and record its pinned-head validation in the rc.1 release gate. Head: Unresolved concerns: none Supporting analysis and execution detailsConclusion: Proceed The commit matches the planned four-file dependency update, with no new configuration, abstractions, application behavior, or unrelated dependencies. The packet reports clean frozen installs, passing local and hosted checks, and working SSR, RSC interactions, error fallback, and recovery on the deployed review app. Validation retries addressed host conditions, and unrelated lockfile updates were removed before commit. This does not indicate approach-level review churn. Alternative considered: Keeping rc.0 would lose validation of the published rc.1 packages in this reference app. Existing tests and browser checks already provide the needed validation without additional implementation. observed model: UNKNOWN; configured model: gpt-6.1-sol · recorded effort: medium Prompt: Shaka default. [
{
"configuration": [
"openai",
"gpt-6.1-sol",
"UNKNOWN",
"medium"
],
"usage": {
"input_tokens": 18028,
"cached_input_tokens": 12288,
"cache_write_input_tokens": 0,
"output_tokens": 283,
"reasoning_output_tokens": 52,
"total_tokens": 18311
}
},
{
"configuration": [
"openai",
"gpt-6.1-sol",
"UNKNOWN",
"medium"
],
"usage": {
"input_tokens": 25202,
"cached_input_tokens": 12288,
"cache_write_input_tokens": 0,
"output_tokens": 374,
"reasoning_output_tokens": 85,
"total_tokens": 25576
}
}
]Ruby verified report shape and head binding. The reviewer judged value; the task owner handles concerns and merge readiness. This does not attest to technical review. |
justin808
added
the
awaiting-merge-approval
|
Squash commit message for |
|
+review-app-delete |
|
No description provided. |
✅ Review App DeletedReview app for PR #853 is deleted |
|
No description provided. |
✅ Review App DeletedReview app for PR #853 is deleted |
justin808
removed
the
awaiting-merge-approval
🤖 Claude Code · Anthropic · claude-opus-5-5 · medium
The tutorial now runs the published React on Rails 17.2.0 rc.1 packages, so release gate shakacode/react_on_rails#5121 can validate the candidate on this Pro and RSC app. The Pro gem and the Pro and Node renderer npm packages are pinned to rc.1; the core gem and package follow through the lockfiles. React and ReactDOM stay on 19.2.8 with react-on-rails-rsc 19.3.0. Merged as
90cdda6.PR prepared with Shaka.
Code Walkthrough · Post-implementation verification
Known gaps
The README version targets still list 17.1.0, as they did before this change. Updating them is left out to keep this bump to the packages only.
The review app for this PR was removed after its smoke passed, so there is no live preview. One request to it returned a 504 after about 11 hours idle and the following requests succeeded; the cause is unclassified.
Execution provenance
c5ad73dUsage and cost · $12.61+ estimated
+ some usage not reported, so the amount is a minimum.
What the columns mean
How each report was measured and priced
claude‑opus‑5‑5 implementation
Rate card: installed Shaka.
Anthropic API list prices, verified 2026-09-23. Uncached input, cache reads and cache writes are separate charges, and a 1-hour cache write costs more than a 5-minute one. Standard-speed responses are priced; fast mode is priced for Opus models with a published rate.
Partial estimate: 2 of 98 responses unpriced (Inconsistent token subsets).
Sources: Anthropic pricing.
Anthropic input excludes cached input and cache writes; reasoning output is part of output.
Local adversarial reviewer usage: UNKNOWN. External reviewer/tool-model usage: UNKNOWN.
Native usage is PARTIAL. Scope: responses at or after 2026-10-08T08:30:00Z (whole-second sources include the cutoff second).
claude‑opus‑5‑5 review
Rate card: installed Shaka.
Anthropic API list prices, verified 2026-09-23. Uncached input, cache reads and cache writes are separate charges, and a 1-hour cache write costs more than a 5-minute one. Standard-speed responses are priced; fast mode is priced for Opus models with a published rate.
Sources: Anthropic pricing.
Anthropic input excludes cached input and cache writes; reasoning output is part of output.
Local adversarial reviewer usage: included below. External reviewer/tool-model usage: UNKNOWN.
Native usage is PARTIAL. Scope: all turns in selected sources.
Rate card: installed Shaka.
Anthropic API list prices, verified 2026-09-23. Uncached input, cache reads and cache writes are separate charges, and a 1-hour cache write costs more than a 5-minute one. Standard-speed responses are priced; fast mode is priced for Opus models with a published rate.
Partial estimate: 2 of 98 responses unpriced (Inconsistent token subsets).
Sources: Anthropic pricing.
Anthropic input excludes cached input and cache writes; reasoning output is part of output.
Local adversarial reviewer usage: UNKNOWN. External reviewer/tool-model usage: UNKNOWN.
Native usage is PARTIAL. 98 responses. Scope: responses at or after 2026-10-08T08:30:00Z (whole-second sources include the cutoff second).
Shaka settings used
Bound to the current candidate commit.
Local files remain local. This reports operation settings and cannot restore them. It does not prove earlier checks ran. Private merge.preference grants no Auto authority. Private trials default to Ask; explicit user authorization and live required gates govern merging.
Summary by CodeRabbit