Repository navigation
Bump React on Rails packages to 17.2.0 rc.2 - #857
Conversation
Move react_on_rails and react_on_rails_pro to 17.2.0.rc.2 and react-on-rails, react-on-rails-pro and react-on-rails-pro-node-renderer to 17.2.0-rc.2. React and React DOM stay at 19.2.8 with react-on-rails-rsc 19.3.0, so this pairing keeps release coverage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
No description provided. |
|
+review-app-deploy |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe Gemfile and package.json update React on Rails Pro dependencies from release candidate 1 to release candidate 2. ChangesReact on Rails Pro dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The updated dependencies resolve consistently in both lockfiles, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Local Adversarial ReviewReviewed revision: Outcome: No open findings; closed and optional findings are in history. Coverage: anthropic/claude: Supplied diff only; unchanged source and test execution are unavailable to this reviewer. Usage and attribution in the PR description. Review evidence and historyCommit: Finding details
Review coverage: Coverage excerpts may be incomplete or misidentified; inspect the original reports.
Unverified report excerpt · anthropic/claude: - **Inspected:** only the supplied diff (`Gemfile`, `Gemfile.lock`, `package.json`, `yarn.lock`). - **Not inspected:** the checkout at the pinned commit. The file tools refused it as outside the restricted working directory, and the working directory itself is empty. - **Tests run:** none. No rspec, rubocop, `bundle install` or JS install was run, and no CI results were supplied. - **Missing context:** - Whether a `pnpm-lock.yaml` or other JS lockfile exists beside `yarn.lock`. - Whether `Gemfile.lock` has a `CHECKSUMS` section. - Whether any other file pins `17.2.0.rc.1` / `17.2.0-rc.1` (Dockerfiles, CI config, docs, renderer config). - The rc.1 → rc.2 upstream changelog. - Registry confirmation of the new `integrity` hashes and of the rc.2 gemspec dependency list. Execution metadata
Round 1 · d7573dc · anthropic/claude · effort UNKNOWN · 1 findingRepository criteria: supplied (AGENTS.md at 90cdda6) Coverage
Findings
Observations (not classed, not counted):
REVIEWED d7573dc BY anthropic/claude EFFORT UNKNOWN FINDINGS 1 REVIEWED d7573dc BY anthropic/claude EFFORT UNKNOWN FINDINGS 1 |
|
No description provided. |
|
Reviewed: this is a clean RC bump with no issues found.
I only read the diff and did not run the test suite. Please confirm CI is green (rspec, JS build, SSR/node-renderer) before merging, since rc.2 is a prerelease. Check that the node-renderer and the gem versions stay in lockstep at deploy time. |
🎉 Deploy Complete!Open Review AppDeployment successful for PR #857, commit d7573dc 🎮 Control Plane Console |
 |
|
+review-app-delete |
|
No description provided. |
❌ Failed to Delete Review AppFailed to delete review app for PR #857 |
|
+review-app-delete |
|
No description provided. |
✅ Review App DeletedReview app for PR #857 is deleted |
justin808
left a comment
justin808
left a comment
There was a problem hiding this comment.
🤖 Claude Code · Anthropic · claude-opus-5-5 · medium
Native publisher settings unavailable for this host; supplied attribution is unverified.
Code Walkthrough
The app installs React on Rails 17.2.0 rc.2 in place of rc.1, and nothing else in the dependency tree moves.
What changed
Before this change the app ran the rc.1 gems and npm packages. The Pro gem pin and the Pro and Node renderer npm pins now name rc.2. The core gem and core npm package are not declared directly, so they follow through Gemfile.lock and yarn.lock.
What stays the same
React and React DOM remain 19.2.8 and react-on-rails-rsc remains 19.3.0. package.json declares react-on-rails-rsc as the exact version 19.3.0 with no range, so Yarn cannot move to 19.3.1, which is now npm latest and needs React 19.3.0. A plain bundle update also moved io-event and protocol-http2; those were left at their locked versions to keep the diff to the release packages.
Validation and risk
Frozen installs, lint, the test asset build, RSpec and Jest pass on this head, and the Node renderer starts at 17.2.0-rc.2 with no version-check error. A review app built from this head served the home page, the streamed server components page and the RSC payload endpoint. Reverting this commit returns the app to rc.1 with no data or configuration change.
| Gate | Result on d7573dc |
|---|---|
| test (22.x, 3.4.6): Rspec CI, JS CI, Lint CI | success |
| smoke / Demo fleet smoke | success |
| deploy / deploy | success |
| claude-review | success, no issues raised |
| Greptile Review | success |
| CodeRabbit | success |
Walkthrough for commit d7573dcf4a4da99896d53c5b95ef02398e1e66e6. This is a COMMENT, not an approval.
|
🤖 Codex · OpenAI · gpt-6.1-sol (configured) · medium Post-implementation validationPR disposition (task owner): Merge The bump is version-only and every required gate, including the review-app smoke, passed on this head. Next action (task owner): The maintainer merges this head under Ask; the agent does not merge. Verification conclusion: Proceed The change supplies the requested rc.2 release evidence through the tutorial's existing Pro and RSC paths while preserving the specified React pairing. Its four-file scope and absence of added architecture make the maintenance cost proportionate; knowing the result, this remains an appropriate way to validate the candidate. Head: Unresolved concerns: none Required checks, reviews, and merge authority still apply. Supporting analysis and execution detailsConclusion: Proceed The reported installs, CI, renderer startup and deployed SSR/RSC interactions exercise the requested rc.2 pairing with React 19.2.8 and react-on-rails-rsc 19.3.0. One commit changes exactly the four planned dependency files, adding no configuration, abstractions or tests. The dismissed lockfile finding required no repair; the cleanup retry does not indicate an approach problem. The release-gate benefit is proportional to this narrow version update. Downstream adoption impact and incident frequency are unknown; this evidence supports this app's pairing, not universal release compatibility. Alternative considered: Keeping rc.1 would avoid the update but lose reproducible rc.2 coverage in this tutorial. That loss conflicts with the explicit release-gate outcome; the existing app and validation provide the simplest useful approach. observed model: UNKNOWN; configured model: gpt-6.1-sol · recorded effort: medium Prompt: Shaka default. [
{
"configuration": [
"openai",
"gpt-6.1-sol",
"UNKNOWN",
"medium"
],
"usage": {
"input_tokens": 17912,
"cached_input_tokens": 12288,
"cache_write_input_tokens": 0,
"output_tokens": 369,
"reasoning_output_tokens": 25,
"total_tokens": 18281
}
},
{
"configuration": [
"openai",
"gpt-6.1-sol",
"UNKNOWN",
"medium"
],
"usage": {
"input_tokens": 24468,
"cached_input_tokens": 17792,
"cache_write_input_tokens": 0,
"output_tokens": 406,
"reasoning_output_tokens": 82,
"total_tokens": 24874
}
}
]Ruby verified report shape and head binding. The reviewer judged value; the task owner handles concerns and merge readiness. This does not attest to technical review. |
justin808
added
the
awaiting-merge-approval
|
Squash commit message for |
|
No description provided. |
✅ Review App DeletedReview app for PR #857 is deleted |
justin808
removed
the
awaiting-merge-approval
🤖 Claude Code · Anthropic · claude-opus-5-5 · medium
Native publisher settings unavailable for this host; supplied attribution is unverified.
The tutorial now runs the published React on Rails 17.2.0 rc.2 packages, the intended final candidate tracked in release gate shakacode/react_on_rails#5121. The Pro gem and the Pro and Node renderer npm packages are pinned to rc.2; the core gem and package follow through the lockfiles. React and React DOM stay on 19.2.8 with react-on-rails-rsc 19.3.0, which the exact pin in package.json holds even though 19.3.1 is now npm latest. Merged as
240188a; master CI and the staging deploy passed afterwards.PR prepared with Shaka.
Code Walkthrough · Post-implementation verification
Known gaps
The review app for this PR was deleted after its smoke passed, so there is no live preview. The first delete attempt failed when the Control Plane API returned a 500 while removing the Postgres volume set; one retry removed everything. The README version targets still list 17.1.0, as before this change.
Execution provenance
6d0bddfUsage and cost · $5.29 estimated
Understand the columns and accounting rules.
How each report was measured and priced
claude‑opus‑5‑5 implementation
Rate card: installed Shaka.
Anthropic API list prices, verified 2026-09-23.
Sources: Anthropic pricing.
Local adversarial reviewer usage: UNKNOWN. External reviewer/tool-model usage: UNKNOWN.
Native usage is PARTIAL. Scope: all turns in selected sources.
claude‑opus‑5‑5 review
Rate card: installed Shaka.
Anthropic API list prices, verified 2026-09-23.
Sources: Anthropic pricing.
Local adversarial reviewer usage: included below. External reviewer/tool-model usage: UNKNOWN.
Native usage is PARTIAL. Scope: all turns in selected sources.
Rate card: installed Shaka.
Anthropic API list prices, verified 2026-09-23.
Sources: Anthropic pricing.
Local adversarial reviewer usage: UNKNOWN. External reviewer/tool-model usage: UNKNOWN.
Native usage is PARTIAL. 64 responses. Scope: all turns in selected sources.
Shaka settings used
UNKNOWN: rerun missing evidence.
Local files remain local. This reports operation settings and cannot restore them. It does not prove earlier checks ran. Private merge.preference grants no Auto authority. Private trials default to Ask; explicit user authorization and live required gates govern merging.
Summary by CodeRabbit