Skip to content

Say where each cpflow cohort loads its actions - #859

Closed
justin808 wants to merge 1 commit into
masterfrom
justin808-claude/5121-cpflow-6-comment-canary
Closed

justin808 wants to merge 1 commit into
masterfrom
justin808-claude/5121-cpflow-6-comment-canary

Conversation

@justin808

@justin808 justin808 commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

🤖 Claude Code · Anthropic · claude-opus-5-5 · medium

Corrects one sentence in the GitHub Actions testing note: since #858 the review-app workflows run the cpflow actions checked in under .github/actions/cpflow-*, while the v5.2.0 workflows still load theirs from upstream.

This PR also serves as the post-merge canary for #858. Comment commands run the default-branch workflows, so +review-app-deploy and +review-app-delete here are the first comment-triggered runs on cpflow 6.0.0. Results are recorded in the comments below.

Docs only; no tests apply.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified testing guidance for workflows: v5.2.0 workflows use shared actions from the upstream source, while 6.0.0 review-app workflows use checked-in actions.
    • Added guidance not to duplicate the ref input in downstream wrappers.

The GitHub Actions testing note still described only upstream-loaded
actions. The 6.0.0 review-app workflows run the checked-in local ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:
They require the repository to have cpflow review apps configured, including the CPLN_TOKEN_STAGING secret.

+review-app-deploy

Deploy your PR branch for testing.

+review-app-delete

Remove the review app when done.

+review-app-help

Show detailed instructions, environment setup, and configuration options.

Comment +review-app-help for full setup details.

@github-actions

Copy link
Copy Markdown

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T07:21:01.078844Z 6605703 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 67f3bee4-47cd-4516-a52e-83c04449464e

📥 Commits

Reviewing files that changed from the base of the PR and between 23cbd83 and 6605703.


📒 Files selected for processing (1)
  • .github/testing-github-actions.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.



Walkthrough

The testing guidance now distinguishes action loading for v5.2.0 workflows and 6.0.0 review-app workflows. It retains the instruction not to add a duplicate ref input to downstream wrappers.

Changes

Workflow testing guidance

Layer / File(s) Summary
Action loading guidance
.github/testing-github-actions.md
The guidance says v5.2.0 workflows load matching shared actions from upstream, while 6.0.0 review-app workflows run checked-in actions. It retains the instruction not to add a duplicate ref input to downstream wrappers.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 66057

The testing guidance accurately distinguishes the two workflow cohorts and clarifies the wrapper ref-input instruction. No merge-blocking issue is identified.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main documentation change: it explains where each cpflow cohort loads its actions.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@justin808

Copy link
Copy Markdown
Member Author

+review-app-deploy

@claude

claude Bot commented Oct 10, 2026

Copy link
Copy Markdown

Review: docs-only change. I checked it against the repo and the new wording is accurate.

  • The 6.0.0 deploy and delete review-app workflows are pinned to 68b5d83…, and .github/actions/cpflow-* exists in the repo.
  • The v5.2.0 workflows and actions still reference shakacode/control-plane-flow/...@1d1ec7f…. For example, cpflow-promote-staging-to-production.yml loads cpflow-validate-config and cpflow-setup-environment from upstream.

One optional nit: "the 6.0.0 review-app workflows run the actions checked in" depends on how the reusable workflow resolves its local actions. I didn't verify that, so it's worth confirming on the canary run.

No security or performance concerns. LGTM.

@github-actions

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

🎉 Deploy Complete!

Open Review App

Deployment successful for PR #859, commit 6605703

🎮 Control Plane Console
📋 View Completed Action Build and Deploy Logs

@github-actions
github-actions Bot temporarily deployed to review/qa-react-webpack-rails-tutorial-859 October 10, 2026 07:21 Destroyed
@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low impact] This documentation-only change appears safe to merge.

Summary

Updates the GitHub Actions testing note to distinguish where each cpflow cohort loads its actions.

  • The testing note names where each cpflow cohort gets its actions.

No actionable issues found. No tests were run for this documentation-only change.

Reviews (1) · Last reviewed commit: "Say where each cpflow cohort loads its a..." · Reviewed by Greptile

@justin808

Copy link
Copy Markdown
Member Author

+review-app-delete

@github-actions

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

✅ Review App Deleted

Review app for PR #859 is deleted

🎮 Control Plane Console
📋 View Workflow Logs

@justin808

Copy link
Copy Markdown
Member Author

🤖 Claude Code · Anthropic · claude-opus-5-5 · medium

Canary result for #858: the comment-triggered deploy and delete both ran the default-branch cpflow 6.0.0 workflows at 23cbd83 and succeeded. The app served /, the streamed /server-components page with toggle, Refresh, Simulate Error and Retry, and /rsc_payload/LiveActivity; the delete removed the app, image and deployment.

Closing without merging: the sentence this PR adds describes checked-in cpflow actions, which #862 removes by moving to cpflow 6.0.1.

@justin808 justin808 closed this Oct 11, 2026
@justin808
justin808 deleted the justin808-claude/5121-cpflow-6-comment-canary branch October 11, 2026 08:33
@github-actions

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

✅ Review App Deleted

Review app for PR #859 is deleted

🎮 Control Plane Console
📋 View Workflow Logs

This branch was successfully deployed

No deployments
review/qa-react-webpack-rails-tutorial-859 — 66057034 Deployed Oct 10, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant