Repository navigation
Conversation
cpflow 6.0.1 loads its composite actions from the pinned upstream ref again, so the review-app deploy and delete callers no longer read .github/actions/cpflow-*. - Bump the cpflow gem to 6.0.1. - Repin both callers to the v6.0.1 commit (6aa575780f2d9175755881b79cbb3253adbc9c1f). - Remove the eight checked-in action copies. - Make the contract check reject any leftover copy instead of comparing the copies with the gem; the shell-input specs read the released actions from the bundled gem. - Update the docs that described the copies. Staging, cleanup, help, and promotion stay on v5.2.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
No description provided. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe review-app deploy and delete workflows and local cpflow gem move to version 6.0.1. The repository removes checked-in cpflow actions. The contract checker and tests now validate the pinned release and reject local action copies. ChangesReview-app workflow migration
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Merge Risk: ⚪ Minimal · up to The migration is mergeable after normal checks; no remaining workflow was found to depend on the removed local actions. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (9 skipped: 9 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main changes: upgrading review apps to cpflow 6.0.1 and removing local action copies. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (9 skipped: 9 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Reviewed the diff. No blocking issues.
🤖 Generated with Claude Code |
Local validation on 4e9fdfd
The 41 local RSpec failures are all in browser-driven spec files (
Review-app deploy and delete on this branch are still to be dispatched by the maintainer. 🤖 Generated with Claude Code |
 |
|
Closing as superseded by #862, which merged the same cpflow 6.0.1 upgrade and copy removal as a749064 and was proven by a branch-dispatched deploy and delete. No dispatch was run on this branch. Two things here that #862 did not carry over, noted in case they are wanted later: a contract check that fails if a 🤖 Generated with Claude Code |
|
No description provided. |
✅ Review App DeletedReview app for PR #861 is deleted |
Summary
Review apps for this repo now deploy and delete with cpflow 6.0.1, and the eight checked-in
.github/actions/cpflow-*copies are removed.cpflow 6.0.0 ran its composite actions from copies checked in to the caller repository. cpflow 6.0.1 loads them from the pinned upstream ref again (
./.cpflow/.github/actions/cpflow-*), so the copies are unused. See Removing cpflow 6.0.0 action copies.cpflowmoves from 6.0.0 to 6.0.1 inGemfileandGemfile.lock.68b5d83152c02a70eb98ffdc7fd2072e28265fef # v6.0.0to6aa575780f2d9175755881b79cbb3253adbc9c1f # v6.0.1. The callers are otherwise identical to the 6.0.1 gem's templates..github/actions/cpflow-*is removed (8 actions, about 1,280 lines).bin/check-cpflow-review-app-contractkeeps the gem-version and pin checks at 6.0.1. The byte-for-byte copy comparison is replaced by a check that no.github/actions/cpflow-*directory exists.spec/cpflow_review_app_contract_spec.rbfollows the checker. The shell-input specs for the setup and delete actions now read the released actions from the bundled 6.0.1 gem instead of the local copies..github/cpflow-help.md,.github/testing-github-actions.md,.controlplane/readme.md,.controlplane/shakacode-team.md, and.controlplane/docs/testing-cpflow-github-actions.mddescribe the 6.0.1 pin and no longer tell readers to keep copies in sync.Pin provenance
v6.0.1is a lightweight tag on commit6aa575780f2d9175755881b79cbb3253adbc9c1f, the merge of shakacode/control-plane-flow#514 and the tip ofmainat release time. Resolved withgh api repos/shakacode/control-plane-flow/git/ref/tags/v6.0.1and confirmed against a local fetch of the tag.Left unchanged
Staging, stale-review-app cleanup, help, and production promotion stay on their
v5.2.0pin (1d1ec7f7af181c5c6cf07f512ce336dbdb367246), per this repo's split-cohort rule. Only the two review-app callers used the local copies; the 5.2.0 cohort already loads its actions from its own pinned upstream source. The customizedbin/test-cpflow-github-flowvalidator is kept as is.Validation
ruby bin/check-cpflow-review-app-contractreview-app release contract: v6.0.1bin/test-cpflow-github-flowbundle exec rspec spec/cpflow_review_app_contract_spec.rbbundle exec rubocop.agents/bin/validate)Comment commands run the default-branch workflows, so the 6.0.1 callers can only be exercised before merge by dispatching them on this branch.
🤖 Generated with Claude Code
Summary by CodeRabbit