Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ gem "coffee-rails"

# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem "jbuilder"
gem "redis", "~> 5.0"
gem "redis", "~> 6.0"

# bundle exec rake doc:rails generates the API under doc/api.
gem "sdoc", group: :doc
Expand Down Expand Up @@ -71,10 +71,10 @@ group :development, :test do

################################################################################
# Linters and Security
gem "rubocop", "1.69", require: false
gem "rubocop-performance", "1.23.1", require: false
gem "rubocop-rails", "2.29.1", require: false
gem "rubocop-rspec", "3.4.0", require: false
gem "rubocop", "1.92.2", require: false
gem "rubocop-performance", "1.27.0", require: false
gem "rubocop-rails", "2.38.0", require: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update code for the newly enabled status-name cop

With .rubocop.yml setting AllCops: NewCops: enable, upgrading rubocop-rails from 2.29.1 to 2.38.0 enables the pending Rails/HttpStatusNameConsistency cop introduced in 2.34. It rejects the two existing status: :unprocessable_entity calls in app/controllers/comments_controller.rb:42 and :56, so the bundle exec rake lint step in .github/workflows/lint_test.yml exits nonzero; update those status names or explicitly configure the cop as part of this bump.

AGENTS.md reference: AGENTS.md:L18-L19

Useful? React with 👍 / 👎.

gem "rubocop-rspec", "3.10.2", require: false
# Critical that require: false be set! https://github.com/brigade/scss-lint/issues/278
gem "scss_lint", require: false

Expand All @@ -97,12 +97,12 @@ end
group :test do
gem "capybara"
gem "capybara-screenshot"
gem "coveralls_reborn", "~> 0.25.0", require: false
gem "coveralls_reborn", "~> 1.0.0", require: false
gem "database_cleaner"
gem "generator_spec"
gem "launchy"
gem "rails_best_practices"
gem "rspec-rails", "~> 6.0.0"
gem "rspec-rails", "~> 8.0.4"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the fixture setting before adopting RSpec Rails 8

When any Rails-backed spec loads spec/rails_helper.rb, its config.fixture_path = ... call on line 49 now raises NoMethodError because RSpec Rails 8 removed the singular setting and registers only fixture_paths. Consequently, most of the RSpec suite fails during configuration before running an example; update the helper to assign an array to config.fixture_paths as part of this major-version bump.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Migrate to the plural fixture path setting

With rspec-rails 8.0.4, loading any spec reaches spec/rails_helper.rb:49, which still calls config.fixture_path = ...; version 8 removed that singular setting and registers only fixture_paths, so the documented RSpec suite raises NoMethodError before running any examples. Update the helper to assign an array to config.fixture_paths as part of this upgrade.

AGENTS.md reference: AGENTS.md:L15-L16

Useful? React with 👍 / 👎.

gem "selenium-webdriver", "~> 4"
end

Expand Down
Loading
Loading