Skip to content

Update loofah, nokogiri and rails-html-sanitizer to clear advisories - #878

Merged
justin808 merged 1 commit into
masterfrom
fix/bump-loofah-nokogiri-advisories
Nov 4, 2026
Merged

justin808 merged 1 commit into
masterfrom
fix/bump-loofah-nokogiri-advisories

Conversation

@justin808

Copy link
Copy Markdown
Member

Summary

New ruby-advisory-db entries flag the locked loofah (< 2.25.3), nokogiri (1.19.4) and rails-html-sanitizer (< 1.7.2), which turns bundler-audit red on any run (seen on TanStack main, not caused by the rc.3 bump). This is a conservative relock: bundle lock --update loofah nokogiri rails-html-sanitizer --conservative.

  • loofah -> 2.25.3, nokogiri -> 1.19.7, rails-html-sanitizer -> 1.7.2
  • every platform entry already in the lockfile is kept; nothing else moves
  • Gemfile.lock is the only changed file

rails-html-sanitizer was added to the requested pair because the same advisory run flags it (>= 1.7.2); Hacker News did the same in its #127.

Verification

  • bundle check passes; Nokogiri 1.19.7 / Loofah 2.25.3 / Rails::HTML::Sanitizer 1.7.2 load under bundle exec.
  • bundler-audit check reports no remaining advisories for these three gems. See PR checks for the full CI run.

Conservative relock (loofah 2.25.3, nokogiri 1.19.7, rails-html-sanitizer
1.7.2) that keeps every platform entry already in the lockfile. Gemfile.lock
only.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Gemfile.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eb5ccf59-868b-449a-a29c-44626a8c997c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T01:48:45.101072Z 84235b4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:
They require the repository to have cpflow review apps configured, including the CPLN_TOKEN_STAGING secret.

+review-app-deploy

Deploy your PR branch for testing.

+review-app-delete

Remove the review app when done.

+review-app-help

Show detailed instructions, environment setup, and configuration options.

Comment +review-app-help for full setup details.

@claude

claude Bot commented Nov 4, 2026

Copy link
Copy Markdown

Review: this only bumps Gemfile.lock (nokogiri 1.19.4 → 1.19.7, loofah 2.25.2 → 2.25.3, rails-html-sanitizer 1.7.1 → 1.7.2). The versions stay within the existing constraints, and Gemfile is unchanged. These are patch-level security/sanitizer updates, so there are no code-quality, performance or security concerns from the diff. I didn't run the test suite. Please make sure CI is green, since the sanitizer changes could affect any rendered HTML output. LGTM.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

No description provided.

@justin808
justin808 merged commit 88f9642 into master Nov 4, 2026
9 checks passed
@justin808
justin808 deleted the fix/bump-loofah-nokogiri-advisories branch November 4, 2026 01:55
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

✅ Review App Deleted

Review app for PR #878 is deleted

🎮 Control Plane Console
📋 View Workflow Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant