refactor(ui): name the failure policy instead of an empty catch

The 21 empty catch blocks each carried a sentence saying why an error was
swallowed. Under the allowlist that sentence is allowed to stay — the body of
an empty block is one of the four kinds of comment the rule keeps — but the
comment was never the best form for it. None of these needed a comment. They
needed a name.

utils/failure.ts holds four, each documented with when it is the right one:
ignoreFailure and nullOnFailure for .catch(), attempt for a synchronous call
that may not be there at all, and succeeded for a call whose error is already
recorded somewhere the screen reads.

Most sites did not even need those. The failure had an answer the code was not
stating: parseMessage returns null, because a frame that is not JSON is
ordinary terminal output; loadConfig falls back in the expression, so the
default is visible in the data flow; markWelcomeSeen returns whether it stuck,
mirroring hasSeenWelcome; listRecordings reads each sidecar through a helper
returning RecordingMeta | null, so a corrupt one is skipped by an if; and four
react-query call sites used mutateAsync inside a try that discarded the
rejection, where mutate() reports through the mutation's own state.

ForgotPassword keeps its reason in the code, as a name:

    const silenceToPreventAccountEnumeration = ignoreFailure;
    await recoverPassword({ ... }).catch(silenceToPreventAccountEnumeration);

Two behaviours are better than before rather than merely equivalent: Chatwoot
records the identity only when setUser actually succeeded, and the settings
toggles clear their busy flag through onSettled instead of a finally that ran
whether or not the mutation was still relevant.

This is the same change as on the total-ban branch, where it removes 21 lint
suppressions. Here it removes 21 comments the rule would have allowed, which
is the more interesting result: the allowance was carrying code that wanted
rewriting.

Author: otavio

ui/apps/console/src/components/common/ConfirmDialog.tsx

@@ -4,6 +4,7 @@ import { Button, type ButtonVariant } from "@shellhub/design-system/primitives";
 import { cn } from "@shellhub/design-system/cn";
 import { useResetOnOpen } from "@/hooks/useResetOnOpen";
 import BaseDialog from "./BaseDialog";
+import { ignoreFailure } from "@/utils/failure";
 
 interface ConfirmDialogProps {
   /** Controls open/close state. */
@@ -82,15 +83,11 @@ export default function ConfirmDialog({
     setConfirming(false);
   });
 
-  const handleConfirm = async () => {
+  const handleConfirm = () => {
     setConfirming(true);
-    try {
-      await onConfirm();
-    } catch {
-      // Errors are not surfaced here. Consumers manage their own error state
-    } finally {
-      setConfirming(false);
-    }
+    void Promise.resolve(onConfirm())
+      .catch(ignoreFailure)
+      .finally(() => setConfirming(false));
   };
 
   const buttonVariant = VARIANT_BUTTON[variant];

ui/apps/console/src/components/common/CreateNamespace.tsx

@@ -23,6 +23,7 @@ import {
   GithubIcon,
   Spinner,
 } from "@shellhub/design-system/primitives";
+import { nullOnFailure } from "@/utils/failure";
 
 export function NamespaceCreateForm() {
   const [name, setName] = useState("");
@@ -113,17 +114,15 @@ export function CommunityInstructions() {
 
   useEffect(() => {
     const check = async () => {
-      try {
-        const { data } = await getNamespaces({
-          query: { page: 1, per_page: 1 },
-          throwOnError: true,
-        });
-        if (data.length > 0) {
-          setReady(true);
-          setTenantId(data[0].tenant_id);
-        }
-      } catch {
-        // ignore
+      const result = await getNamespaces({
+        query: { page: 1, per_page: 1 },
+        throwOnError: true,
+      }).catch(nullOnFailure);
+
+      const first = result?.data[0];
+      if (first) {
+        setReady(true);
+        setTenantId(first.tenant_id);
       }
     };
     const interval = setInterval(() => void check(), 5000);

ui/apps/console/src/components/terminal/TerminalInstance.tsx

@@ -27,6 +27,7 @@ import {
 } from "./terminalErrors";
 import SSHApproval from "@/pages/SSHApproval";
 import { cn } from "@shellhub/design-system/cn";
+import { attempt } from "@/utils/failure";
 
 interface TerminalInstanceProps {
   session: TerminalSession;
@@ -137,11 +138,7 @@ export default function TerminalInstance({
       if (!containerRef.current) return;
       term.open(containerRef.current);
 
-      try {
-        term.loadAddon(new WebglAddon());
-      } catch {
-        // DOM renderer fallback
-      }
+      attempt(() => term.loadAddon(new WebglAddon()));
 
       fitAddon.fit();
       const { cols, rows } = term;

ui/apps/console/src/components/terminal/terminalErrors.ts

@@ -175,7 +175,7 @@ export function parseMessage(
       };
     }
   } catch {
-    // Not JSON — regular text frame
+    return null;
   }
   return null;
 }

ui/apps/console/src/env.ts

@@ -1,3 +1,5 @@
+import { nullOnFailure } from "@/utils/failure";
+
 export type Edition = "community" | "enterprise" | "cloud";
 
 export interface ClientConfig {
@@ -35,17 +37,13 @@ export async function loadConfig(): Promise<ClientConfig> {
   if (inflight) return inflight;
 
   inflight = (async () => {
-    try {
-      const res = await fetch("/config.json");
-      cached = {
-        ...defaultConfig,
-        ...((await res.json()) as Partial<ClientConfig>),
-      };
-    } catch {
-      // leave cached as defaultConfig so future calls can retry
-    } finally {
-      inflight = null;
-    }
+    const fetched = await fetch("/config.json")
+      .then((res) => res.json() as Promise<Partial<ClientConfig>>)
+      .catch(nullOnFailure);
+
+    cached = fetched ? { ...defaultConfig, ...fetched } : defaultConfig;
+    inflight = null;
+
     return cached;
   })();
 

ui/apps/console/src/hooks/chatwootRuntime.ts

@@ -1,3 +1,4 @@
+import { attempt } from "@/utils/failure";
 /**
  * Module-level lifecycle for the Chatwoot SDK. Lives outside the React tree
  * so `authStore.logout()` can tear it down without going through a hook, and
@@ -156,12 +157,10 @@ export function tearDownChatwoot(
   clearWatchdog();
   detachReadyListener();
 
-  try {
+  attempt(() => {
     window.$chatwoot?.toggle("close");
     window.$chatwoot?.reset();
-  } catch {
-    // Widget mid-bootstrap — nothing to close.
-  }
+  });
 
   document.getElementById(SCRIPT_ID)?.remove();
   document.querySelectorAll(SDK_DOM_SELECTORS).forEach((node) => node.remove());

ui/apps/console/src/hooks/useChatwoot.ts

@@ -18,6 +18,7 @@ import {
   injectChatwootScript,
   subscribeChatwootState,
 } from "@/hooks/chatwootRuntime";
+import { attempt } from "@/utils/failure";
 
 export type ChatwootStatus =
   "non-cloud" | "unavailable" | "no-subscription" | "loading" | "ready";
@@ -101,16 +102,15 @@ export function useChatwoot(): ChatwootHandle {
     ].join("|");
     if (lastIdentityRef.current === key) return;
 
-    try {
+    const identified = attempt(() => {
       window.$chatwoot?.setUser(userId, {
         email: userEmail ?? undefined,
         name: userName ?? undefined,
         identifier_hash: identifier,
       });
-      lastIdentityRef.current = key;
-    } catch {
-      // Widget reset between effect setup and call — next change retries.
-    }
+    });
+
+    if (identified) lastIdentityRef.current = key;
   }, [widgetReady, userId, userEmail, userName, tenant, identifier]);
 
   useEffect(() => {
@@ -120,15 +120,13 @@ export function useChatwoot(): ChatwootHandle {
     const onMessage = () => {
       if (fired) return;
       fired = true;
-      try {
+      attempt(() => {
         window.$chatwoot?.setConversationCustomAttributes({
           namespace: namespaceName,
           tenant,
           domain: window.location.hostname,
         });
-      } catch {
-        // Ignore — Chatwoot may not expose the API in older builds.
-      }
+      });
     };
 
     window.addEventListener("chatwoot:on-message", onMessage);
@@ -137,11 +135,7 @@ export function useChatwoot(): ChatwootHandle {
 
   const openWidget = useCallback(() => {
     if (!widgetReady) return;
-    try {
-      window.$chatwoot?.toggle("open");
-    } catch {
-      // Widget not yet attached — no-op.
-    }
+    attempt(() => window.$chatwoot?.toggle("open"));
   }, [widgetReady]);
 
   let status: ChatwootStatus;

ui/apps/console/src/pages/ForgotPassword.tsx

@@ -14,6 +14,9 @@ import {
   type ForgotPasswordFormValues,
 } from "./setup/forgotPasswordResolver";
 import LoginLayoutCard from "@/components/layout/LoginLayoutCard";
+import { ignoreFailure } from "@/utils/failure";
+
+const silenceToPreventAccountEnumeration = ignoreFailure;
 
 export default function ForgotPassword() {
   const [loading, setLoading] = useState(false);
@@ -28,17 +31,14 @@ export default function ForgotPassword() {
 
   const onSubmit = async (values: ForgotPasswordFormValues) => {
     setLoading(true);
-    try {
-      await recoverPassword({
-        body: { username: values.account },
-        throwOnError: true,
-      });
-    } catch {
-      // Silently ignore to prevent user enumeration.
-    } finally {
-      setLoading(false);
-      setSent(true);
-    }
+
+    await recoverPassword({
+      body: { username: values.account },
+      throwOnError: true,
+    }).catch(silenceToPreventAccountEnumeration);
+
+    setLoading(false);
+    setSent(true);
   };
 
   return (

ui/apps/console/src/pages/MfaResetRequest.tsx

@@ -7,6 +7,7 @@ import { useAuthStore } from "../stores/authStore";
 import { useMfaResetStore } from "../stores/mfaResetStore";
 import AuthFooterLinks from "../components/common/AuthFooterLinks";
 import LoginLayoutCard from "@/components/layout/LoginLayoutCard";
+import { succeeded } from "@/utils/failure";
 
 export default function MfaResetRequest() {
   const { user, username, mfaToken } = useAuthStore();
@@ -32,11 +33,8 @@ export default function MfaResetRequest() {
   }
 
   const onSubmit = async () => {
-    try {
-      await requestMfaReset(identifier);
+    if (await succeeded(requestMfaReset(identifier))) {
       void navigate("/mfa-reset-verify");
-    } catch {
-      // Error is set in store
     }
   };
 

ui/apps/console/src/pages/Settings.tsx

@@ -353,11 +353,11 @@ export default function Settings() {
   const sshLegacyAllowed = settings?.ssh_legacy_allowed ?? false;
   const banner = settings?.connection_announcement ?? "";
 
-  const handleToggleRecord = async () => {
+  const handleToggleRecord = () => {
     if (!tenantId || togglingRecord) return;
     setTogglingRecord(true);
-    try {
-      await editNs.mutateAsync({
+    editNs.mutate(
+      {
         path: { tenant: tenantId },
         body: {
           settings: {
@@ -366,27 +366,21 @@ export default function Settings() {
             ssh_access_mode: sshAccessMode,
           },
         },
-      });
-    } catch {
-      /* state didn't change */
-    } finally {
-      setTogglingRecord(false);
-    }
+      },
+      { onSettled: () => setTogglingRecord(false) },
+    );
   };
 
-  const handleSetAccessMode = async (mode: "legacy" | "identity") => {
+  const handleSetAccessMode = (mode: "legacy" | "identity") => {
     if (!tenantId || switchingAccessMode || mode === sshAccessMode) return;
     setSwitchingAccessMode(true);
-    try {
-      await setSshAccessMode.mutateAsync({
+    setSshAccessMode.mutate(
+      {
         path: { tenant: tenantId },
         body: { ssh_access_mode: mode },
-      });
-    } catch {
-      /* state didn't change */
-    } finally {
-      setSwitchingAccessMode(false);
-    }
+      },
+      { onSettled: () => setSwitchingAccessMode(false) },
+    );
   };
 
   if (!ns) {
@@ -478,7 +472,7 @@ export default function Settings() {
                 <button
                   type="button"
                   onClick={() => {
-                    if (sessionRecord) void handleToggleRecord();
+                    if (sessionRecord) handleToggleRecord();
                   }}
                   className={cn(
                     "h-full px-2.5 text-2xs font-medium rounded transition-all duration-150",
@@ -492,7 +486,7 @@ export default function Settings() {
                 <button
                   type="button"
                   onClick={() => {
-                    if (!sessionRecord) void handleToggleRecord();
+                    if (!sessionRecord) handleToggleRecord();
                   }}
                   className={cn(
                     "h-full px-2.5 text-2xs font-medium rounded transition-all duration-150",
@@ -544,7 +538,7 @@ export default function Settings() {
               >
                 <button
                   type="button"
-                  onClick={() => void handleSetAccessMode("legacy")}
+                  onClick={() => handleSetAccessMode("legacy")}
                   className={`h-full px-2.5 text-2xs font-medium rounded transition-all duration-150 ${
                     sshAccessMode === "legacy"
                       ? "bg-hover-strong text-text-secondary border border-border-light"
@@ -555,7 +549,7 @@ export default function Settings() {
                 </button>
                 <button
                   type="button"
-                  onClick={() => void handleSetAccessMode("identity")}
+                  onClick={() => handleSetAccessMode("identity")}
                   className={`h-full px-2.5 text-2xs font-medium rounded transition-all duration-150 ${
                     sshAccessMode === "identity"
                       ? "bg-primary/15 text-primary border border-primary/25"