[1/2] Mise-fy toolchain + hk linters + GHA - #1
Merged
Conversation
Replace Travis with mise + hk (check/test workflows) so local hooks and CI share one lint contract. Pin Go 1.25, sync go.mod/vendor markers for modern modules, and document setup in README/AGENTS.
The hk builtin only defined fix, so CI and mise run check skipped formatting. Add check_diff via gofumpt -d.
Apply gofumpt, fix golangci ineffassign/staticcheck findings, and correct a typos hit so mise run check --all is green on the whole tree.
[2/2] Retrospective lint fixes for Go sources
sherifabdlnaby
marked this pull request as ready for review
July 11, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add mise + hk lint/format contract, replace Travis with GitHub Actions (
check+test), and document setup in README/AGENTS.Changes
mise.toml/mise.lock/hk.pklwith Go + recommended linters (gofumpt, golangci-lint, actionlint/zizmor/pinact, typos, rumdl, lychee offline, betterleaks, …).github/workflows/check.yml(report-only lint) andtest.yml(go test -race).travis.ymlAGENTS.mdgo 1.25.0directive, vendor## explicitmarkers,golang.org/x/syncfor tidygo_fumptcheck_diff so CI actually gates formatting (builtin was fix-only)Note
Stacked under #2. Merge this first.
Repo was unarchived to open these PRs (it was read-only).
Tests & Validation
mise run setup/mise doctorcleanmise run check(staged) greenmise run testgreenRelevant Links
🤖 Created with Cursor (Grok 4.5) on behalf of @sherifabdlnaby, fully autonomous, they have not reviewed this.