[2/2] Retrospective lint fixes for Go sources - #2
Merged
Conversation
Apply gofumpt, fix golangci ineffassign/staticcheck findings, and correct a typos hit so mise run check --all is green on the whole tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clear the existing-tree lint debt so
mise run check --all(and the daily CI sweep) is green after the mise-fy rules land.Changes
gpool.go/gpool_test.go/package.goineffassign(discard unused pre-start enqueue results) + staticcheck redundantreturnReceieved→Receivedin the example testNote
Stacked on #1. Merge #1 first; this PR retargets to
masterafter.Tests & Validation
mise run check --allgreen (including go_fumpt check_diff)mise run testgreenRelevant Links
🤖 Created with Cursor (Grok 4.5) on behalf of @sherifabdlnaby, fully autonomous, they have not reviewed this.