Skip to content

Commit 6a6693f

Browse files
committed
fix: simplify quality change review
1 parent 119eccf commit 6a6693f

35 files changed

Lines changed: 38 additions & 53 deletions

File tree

agents/quality-fixer-frontend.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@ Use the appropriate run command based on the `packageManager` field in package.j
3737

3838
### Step 1: Incomplete Implementation Check [BLOCKING — before any quality checks]
3939

40-
Review the diff of changed files to detect stub or incomplete implementations. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
40+
Review the current uncommitted changes for incomplete implementation using the current task and repository context. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
4141

42-
Derive the current uncommitted write set from `git status --short`. Inspect tracked changes with `git diff HEAD`, read untracked files directly, and account for deleted paths without attempting to read them. The workflow commits each completed unit before the next begins, so this repository state is the quality scope.
43-
44-
Apply the indicators below to each existing file in this write set.
42+
Use the indicators below for this review.
4543

4644
**Indicators of incomplete implementation** (stub_detected):
4745
- `// TODO`, `// FIXME`, `// HACK`, `throw new Error("not implemented")` or equivalent

agents/quality-fixer.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,9 @@ Executes applicable quality checks, fixes in-scope failures, and reports blocker
3434

3535
### Step 1: Incomplete Implementation Check [BLOCKING — before any quality checks]
3636

37-
Review the diff of changed files to detect stub or incomplete implementations. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
37+
Review the current uncommitted changes for incomplete implementation using the current task and repository context. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
3838

39-
Derive the current uncommitted write set from `git status --short`. Inspect tracked changes with `git diff HEAD`, read untracked files directly, and account for deleted paths without attempting to read them. The workflow commits each completed unit before the next begins, so this repository state is the quality scope.
40-
41-
Apply the indicators below to each existing file in this write set.
39+
Use the indicators below for this review.
4240

4341
**Indicators of incomplete implementation** (stub_detected):
4442
- `// TODO`, `// FIXME`, `// HACK`, `throw new Error("not implemented")` or equivalent

dev-workflows-frontend/agents/quality-fixer-frontend.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@ Use the appropriate run command based on the `packageManager` field in package.j
3737

3838
### Step 1: Incomplete Implementation Check [BLOCKING — before any quality checks]
3939

40-
Review the diff of changed files to detect stub or incomplete implementations. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
40+
Review the current uncommitted changes for incomplete implementation using the current task and repository context. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
4141

42-
Derive the current uncommitted write set from `git status --short`. Inspect tracked changes with `git diff HEAD`, read untracked files directly, and account for deleted paths without attempting to read them. The workflow commits each completed unit before the next begins, so this repository state is the quality scope.
43-
44-
Apply the indicators below to each existing file in this write set.
42+
Use the indicators below for this review.
4543

4644
**Indicators of incomplete implementation** (stub_detected):
4745
- `// TODO`, `// FIXME`, `// HACK`, `throw new Error("not implemented")` or equivalent

dev-workflows-frontend/skills/recipe-front-adjust/SKILL.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ When the project-tier file declares no automated verification mechanism for an a
115115
- `subagent_type: "dev-workflows-frontend:quality-fixer-frontend"`
116116
- `description: "Quality verification for adjustment unit"`
117117
- Pass `qualityCommand` when available (caller first, otherwise current task).
118-
- The agent derives the adjustment unit's uncommitted write set from repository status.
119118
- Route the quality-fixer-frontend response by `status`:
120119
- `approved` → proceed to Step 7
121120
- `stub_detected` → return to Step 5 to complete the implementation for this unit, then re-invoke quality-fixer-frontend

dev-workflows-frontend/skills/recipe-front-build/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ For EACH task in the Consumed Task Set, YOU MUST:
100100
- `blocked` → STOP and escalate to user
101101
- `needs_revision` → Pass `qualityIssues` unchanged into the Review Resolution Gate; return to step 1 for rerouted corrections and derive convergence from correction re-review `prior_feedback_reconciliation`
102102
- `status: completed` → Proceed to step 3
103-
3. **QUALITY-FIX**: Invoke quality-fixer-frontend with `task_file`, upstream `mutationEvidence`, and `qualityCommand` when available (caller first, otherwise current task); it derives the uncommitted write set from repository status
103+
3. **QUALITY-FIX**: Invoke quality-fixer-frontend with `task_file`, upstream `mutationEvidence`, and `qualityCommand` when available (caller first, otherwise current task)
104104
- `stub_detected` → Return to step 1 with `incompleteImplementations[]` details
105105
- `blocked` → STOP and escalate to user
106106
- `approved` → Proceed to step 4

dev-workflows-frontend/skills/recipe-front-review/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ Invoke task-executor-frontend using Agent tool:
142142
Invoke quality-fixer-frontend using Agent tool:
143143
- `subagent_type`: "dev-workflows-frontend:quality-fixer-frontend"
144144
- `description`: "Quality gate check"
145-
- Pass Step 6 `mutationEvidence`; quality-fixer-frontend derives the uncommitted correction write set from repository status.
145+
- Pass Step 6 `mutationEvidence`.
146146
- `prompt`: "Confirm quality gate passage for fixed files."
147147

148148
### Step 8: Re-validate code-reviewer

dev-workflows-frontend/skills/subagents-orchestration-guide/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ For Small, execute one direct-scope 4-step cycle and complete when quality-fixer
197197
- `blocked` → Escalate to user
198198
- `needs_revision` → Pass `qualityIssues` objects unchanged into Review Resolution. On correction re-review, derive the next transition only from `prior_feedback_reconciliation`; return to step 1 for rerouted corrections and proceed to step 3 only at convergence
199199
- Otherwise → Proceed to step 3
200-
3. **Quality-fix**: invoke quality-fixer with upstream `mutationEvidence`, plus `task_file` when available and `qualityCommand` from the caller first or task otherwise; quality-fixer derives the current uncommitted write set from repository status
200+
3. **Quality-fix**: invoke quality-fixer with upstream `mutationEvidence`, plus `task_file` when available and `qualityCommand` from the caller first or task otherwise
201201
- `stub_detected` → Return to step 1 with `incompleteImplementations[]` details
202202
- `blocked` → Escalate to user
203203
- `approved` → Proceed to step 4

dev-workflows-fullstack/agents/quality-fixer-frontend.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@ Use the appropriate run command based on the `packageManager` field in package.j
3737

3838
### Step 1: Incomplete Implementation Check [BLOCKING — before any quality checks]
3939

40-
Review the diff of changed files to detect stub or incomplete implementations. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
40+
Review the current uncommitted changes for incomplete implementation using the current task and repository context. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
4141

42-
Derive the current uncommitted write set from `git status --short`. Inspect tracked changes with `git diff HEAD`, read untracked files directly, and account for deleted paths without attempting to read them. The workflow commits each completed unit before the next begins, so this repository state is the quality scope.
43-
44-
Apply the indicators below to each existing file in this write set.
42+
Use the indicators below for this review.
4543

4644
**Indicators of incomplete implementation** (stub_detected):
4745
- `// TODO`, `// FIXME`, `// HACK`, `throw new Error("not implemented")` or equivalent

dev-workflows-fullstack/agents/quality-fixer.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,9 @@ Executes applicable quality checks, fixes in-scope failures, and reports blocker
3434

3535
### Step 1: Incomplete Implementation Check [BLOCKING — before any quality checks]
3636

37-
Review the diff of changed files to detect stub or incomplete implementations. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
37+
Review the current uncommitted changes for incomplete implementation using the current task and repository context. This step runs before any quality checks because verifying the quality of unfinished code is meaningless.
3838

39-
Derive the current uncommitted write set from `git status --short`. Inspect tracked changes with `git diff HEAD`, read untracked files directly, and account for deleted paths without attempting to read them. The workflow commits each completed unit before the next begins, so this repository state is the quality scope.
40-
41-
Apply the indicators below to each existing file in this write set.
39+
Use the indicators below for this review.
4240

4341
**Indicators of incomplete implementation** (stub_detected):
4442
- `// TODO`, `// FIXME`, `// HACK`, `throw new Error("not implemented")` or equivalent

dev-workflows-fullstack/skills/recipe-add-integration-tests/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ Invoke quality-fixer for the current layer:
117117
- Backend or single-layer → `subagent_type`: "dev-workflows-fullstack:quality-fixer"
118118
- Frontend → `subagent_type`: "dev-workflows-fullstack:quality-fixer-frontend"
119119
- `description`: "Final quality assurance"
120-
- Pass the latest executor's `mutationEvidence`; quality-fixer derives the current layer's uncommitted write set from repository status.
120+
- Pass the latest executor's `mutationEvidence`.
121121
- `prompt`: "Final quality assurance for test files added in this workflow. Run all tests and verify coverage."
122122

123123
**Expected output**: `status` (approved/stub_detected/blocked)

0 commit comments

Comments
 (0)