Repository navigation
fix: type the generate request as the fields generation uses - #154
Merged
Merged
Conversation
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Generate Asset reference listed about 40 clip settings and had lost its parameter names. The request reused the timeline
ImageAsset,VideoAssetandAudioAssetschemas, so the reference and the published types offered crop, trim, volume and chroma key, none of which affect a generated asset, and showedpromptand the body as optional. TheoneOfalso rendered as unnamed rows, and the reference's clean-up script, which drops any column holding one, removed every parameter name with it.GenerationAssetholds only what generation reads:type,prompt,modelandoptions. It is one schema rather than one per type because the types differ only in default model and options, whichGET /modelsdocuments.The API accepts the same payloads as before; only the published request type narrows. No released SDK includes
/generate.Verify:
pnpm build && pnpm test && pnpm test:examples && pnpm test:smoke, thenpnpm build:docs. Generate Asset lists named rows forasset,type,prompt,model,optionsandlength.Risk: TypeScript code that builds the generate body from the timeline asset types stops type-checking.