add CI (lint + packaging tests) and extract build.sh

Author: slalabs

.github/workflows/ci.yml

@@ -0,0 +1,57 @@
+name: CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  lint-and-package:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+
+      - name: PHP syntax check (php -l)
+        run: |
+          command -v php >/dev/null || { sudo apt-get update -qq && sudo apt-get install -y -qq php-cli; }
+          fail=0
+          while IFS= read -r -d '' f; do
+            php -l "$f" || fail=1
+          done < <(find . -name '*.php' -not -path './dist/*' -print0)
+          exit $fail
+
+      - name: Validate theme_info.xml
+        run: |
+          command -v xmllint >/dev/null || { sudo apt-get update -qq && sudo apt-get install -y -qq libxml2-utils; }
+          xmllint --noout theme_info.xml
+
+      - name: ShellCheck build.sh
+        run: |
+          command -v shellcheck >/dev/null || { sudo apt-get update -qq && sudo apt-get install -y -qq shellcheck; }
+          shellcheck build.sh   # deploy.sh ist nicht im Repo (server-only) und wird lokal geprüft
+
+      - name: Packaging smoke test
+        run: |
+          chmod +x build.sh
+          ZIP="$(./build.sh 9.9.9-citest | tail -n1)"
+          echo "Built: $ZIP"
+
+          # 1) Wrapper-Ordner + theme_info.xml vorhanden
+          unzip -l "$ZIP" | grep -q 'siduction/theme_info.xml' \
+            || { echo "FAIL: siduction/theme_info.xml fehlt im Zip"; exit 1; }
+
+          # 2) Version korrekt eingebrannt (theme_info.xml UND @version)
+          unzip -p "$ZIP" siduction/theme_info.xml | grep -q '<version>9.9.9-citest</version>' \
+            || { echo "FAIL: Version nicht in theme_info.xml gestempelt"; exit 1; }
+          unzip -p "$ZIP" siduction/index.template.php | grep -q '@version 9.9.9-citest' \
+            || { echo "FAIL: @version nicht in index.template.php gestempelt"; exit 1; }
+
+          # 3) VCS/CI/Ops-Dateien dürfen NICHT im Zip sein
+          if unzip -l "$ZIP" | grep -qE 'deploy\.sh|build\.sh|\.github|\.git/|\.claude'; then
+            echo "FAIL: unerwünschte Dateien im Zip:"; unzip -l "$ZIP"; exit 1
+          fi
+
+          echo "OK: Packaging-Assertions bestanden"

.github/workflows/release.yml

@@ -16,30 +16,13 @@ jobs:
 
       - name: Derive version from tag
         id: ver
-        run: |
-          VERSION="${GITHUB_REF_NAME#v}"        # v1.0 -> 1.0
-          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+        run: echo "version=${GITHUB_REF_NAME#v}" >> "$GITHUB_OUTPUT"   # v1.0 -> 1.0
 
-      - name: Stamp version into theme files
-        env:
-          VERSION: ${{ steps.ver.outputs.version }}
-        run: |
-          sed -i -E "s|<version>[^<]*</version>|<version>${VERSION}</version>|" theme_info.xml
-          sed -i -E "s|(@version[[:space:]]+).*|\1${VERSION}|" index.template.php
-          grep -n "<version>" theme_info.xml
-          grep -n "@version" index.template.php
-
-      - name: Build theme zip (wrapped in siduction/)
-        env:
-          VERSION: ${{ steps.ver.outputs.version }}
+      - name: Build theme zip
+        id: build
         run: |
-          rm -rf dist && mkdir -p dist/siduction
-          rsync -a \
-            --exclude='.git' --exclude='.github' --exclude='.gitignore' \
-            --exclude='deploy.sh' --exclude='dist' --exclude='.DS_Store' \
-            ./ dist/siduction/
-          (cd dist && zip -r -q "siduction-${VERSION}.zip" siduction)
-          ls -lah dist
+          chmod +x build.sh
+          echo "zip=$(./build.sh "${{ steps.ver.outputs.version }}" | tail -n1)" >> "$GITHUB_OUTPUT"
 
       - name: Create GitHub release
         env:
@@ -49,6 +32,6 @@ jobs:
           PRERELEASE=""
           case "$VERSION" in *-*) PRERELEASE="--prerelease";; esac   # v1.0-rc1 -> prerelease
           gh release create "$GITHUB_REF_NAME" \
-            "dist/siduction-${VERSION}.zip" \
+            "${{ steps.build.outputs.zip }}" \
             --title "Siduction $VERSION" \
             --generate-notes $PRERELEASE

build.sh

@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+# Baut das installierbare SMF-Theme-Zip mit eingebrannter Version.
+# Mutiert den Quellbaum NICHT — gestempelt wird nur im Staging-Verzeichnis.
+# Einzige Quelle der Wahrheit fürs Packaging (von release.yml UND ci.yml genutzt).
+#
+# Usage: ./build.sh <version> [dist_dir]
+#   Gibt auf der letzten Zeile den Pfad zum erzeugten Zip aus.
+set -euo pipefail
+
+VERSION="${1:?Usage: build.sh <version> [dist_dir]}"
+DIST="${2:-dist}"
+THEME_NAME="siduction"
+
+ROOT="$(cd "$(dirname "$0")" && pwd)"
+STAGE="${DIST}/${THEME_NAME}"
+
+# Portable In-Place-Ersetzung (GNU- und BSD-sed): in Temp schreiben, dann mv.
+stamp() {  # stamp <datei> <sed-expr>
+  sed -E "$2" "$1" > "$1.tmp" && mv "$1.tmp" "$1"
+}
+
+rm -rf "$DIST"
+mkdir -p "$STAGE"
+
+# Theme-Dateien ins Staging spiegeln (VCS/CI/Ops/OS-Kram raus)
+rsync -a \
+  --exclude='.git' --exclude='.github' --exclude='.gitignore' \
+  --exclude='.claude' --exclude='deploy.sh' --exclude='build.sh' \
+  --exclude='dist' --exclude='.DS_Store' \
+  "${ROOT}/" "$STAGE/"
+
+# Version einbrennen (nur im Staging)
+stamp "${STAGE}/theme_info.xml"      "s|<version>[^<]*</version>|<version>${VERSION}</version>|"
+stamp "${STAGE}/index.template.php"  "s|(@version[[:space:]]+).*|\1${VERSION}|"
+
+# Zip mit umschließendem siduction/-Ordner
+( cd "$DIST" && zip -r -q "${THEME_NAME}-${VERSION}.zip" "$THEME_NAME" )
+
+echo "${DIST}/${THEME_NAME}-${VERSION}.zip"