Add marker component for hidden entities that wasn't despawned - #741
Draft
Shatur wants to merge 1 commit into
Draft
Add marker component for hidden entities that wasn't despawned#741Shatur wants to merge 1 commit into
Shatur wants to merge 1 commit into
Conversation
It works, but: - Docs need improvements. - Not sure about the component name. - The logic in server.rs is a bit on a dirty side, I need to clean it.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
==========================================
- Coverage 90.75% 90.71% -0.04%
==========================================
Files 72 72
Lines 4391 4461 +70
==========================================
+ Hits 3985 4047 +62
- Misses 406 414 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works, but: