Repository navigation
fix(providers): refuse an empty Responses input before sending instead of retrying a guaranteed 400 - #9196
Merged
Conversation
…d of retrying a guaranteed 400
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryRejects empty Responses input before sending a request.
Reviews (1) · Last reviewed commit: "fix(providers): refuse an empty Response..." · Reviewed by Greptile |
6 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<start.input>is"") sent the OpenAI Responses APIinput: [], because empty-content messages are dropped when the input is built. OpenAI rejects that with a 400 on every attempt, yet it surfaced as a plain internal error, logged at ERROR, and burned block retries and model fallbacksexecuteResponsesProviderRequestnow refuses an empty input before any request is sent, throwingEmptyProviderInputError— aUserFailure(classified as the author's to fix) withretryable = false(skips block retries and the fallback chain)previous_response_id,prompt, orconversation, so an emptyinputcould never succeed on any of themType of Change
Testing
providers/openai/core.response-status.test.ts: empty system prompt + empty messages rejects with the user failure (isNonRetryableExecutionErrortrue,classifyFailure→user) and never calls fetch; a system-prompt-only request still sends[{ role: 'system', … }]ProviderError: OpenAI API error (400)), green with itChecklist
test-auditauthoring gate)