Repository navigation
fix(mcp): route deferred transport requests under the client's outbound scope - #9199
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. Summary
No actionable issues were found. Tests were inspected, not run.
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifications/cancelledfrom the abort listener, which runs in the async context of whoever calledabort()(e.g. the execute route's timeout timer, created outside the outbound scope)MISSING_SCOPE: the server never learned of the cancellation and kept running abandoned calls, and the transport logged a failed request each timeMcpClientnow captures the outbound scope at construction and wraps its transport fetch: a scope current at call time still wins (pooled clients never pin an organization), the captured scope only fills in when none is current, and a client built outside any scope keeps failing closedcaptureOutboundScopeFallbacklives next tocaptureOutboundScope, which keeps its stricter semantics for isolated-vm callbacksType of Change
Testing
McpClient outbound scopetests run the realAsyncLocalStoragescope: a transport request from outside any scope routes under the constructing organization, a current scope still wins, and an unscoped client still throwsMISSING_SCOPEMISSING_SCOPE), and red with plaincaptureOutboundScope(a current scope is ignored)lib/mcpsuite: 351 passed; comment-hygiene, test-patterns, test-types checks passChecklist
test-auditauthoring gate)