Conversation
Empty/"none" heartbeat types previously fell through to tcpPingService and reported Online whenever a TCP accept succeeded. A wedged service can still accept connections, so that signal was indistinguishable from a real check. Report Warning (and NOT_SERVING) for unconfigured types; keep explicit "tcp" on the dial path. Fixes singnet#694.
Author
|
@StephenLReed @semyon-dev This addresses #694: unconfigured heartbeat types ( Fork CI ( |
MrBeldum
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unconfigured heartbeat types (
""/"none") no longer claimOnlinefrom a TCP accept. They reportWarningwithNOT_SERVINGso consumers can tell an unchecked service from a verified one. Explicit"tcp"still usestcpPingService.Fixes #694.
Changes
GetHeartbeat: route"none"/""away fromtcpPingService; keep"tcp"on the dial pathTestHeartbeatHandlerexpectation to match the unconfigured Warning statusInterface changes
Daemon heartbeat JSON status for unconfigured types is now
"Warning"instead of a false"Online". gRPC healthCheckaccordingly returns non-SERVING for those configs (same as any non-Online status today).Test plan
go test ./metrics/ -count=1