Skip to content

Commit b41829b

Browse files
authored
Fix light aggregation inflation (#71)
* fix phi aggregation bug * update unaffected notebooks * update elephant dependency * fix opto level in video tutorial, put video back in * correct opto level in multi_opto tutorial * correct opto levels in all_optical tutorial * correct opto level in optimal_ctrl tutorial * skip video render on CI
1 parent afd2a1d commit b41829b

13 files changed

Lines changed: 1422 additions & 233 deletions

‎cleo/registry.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
"""Code for orchestrating inter-device interactions.
1+
"""Code for orchestrating inter-device interactions.
22
33
This should only be relevant for developers, not users, as this code is used
44
under the hood when interacting devices are injected (e.g., light and opsin)."""
5+
56
from __future__ import annotations
67

78
from typing import Tuple
@@ -51,7 +52,7 @@ class DeviceInteractionRegistry:
5152
epsilon : 1
5253
Ephoton : joule
5354
Irr_post = epsilon * T * Irr0_pre : watt/meter**2 (summed)
54-
phi_post = Irr_post / Ephoton : 1/second/meter**2 (summed)
55+
phi_post = epsilon * T * Irr0_pre / Ephoton : 1/second/meter**2 (summed)
5556
"""
5657
"""Model used in light propagation synapses"""
5758

‎docs/tutorials/PI_ctrl.ipynb‎

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

‎docs/tutorials/advanced_lfp.ipynb‎

Lines changed: 15 additions & 11 deletions
Large diffs are not rendered by default.

‎docs/tutorials/all_optical.ipynb‎

Lines changed: 12 additions & 15 deletions
Large diffs are not rendered by default.

‎docs/tutorials/electrodes.ipynb‎

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

‎docs/tutorials/multi_opto.ipynb‎

Lines changed: 38 additions & 28 deletions
Large diffs are not rendered by default.

‎docs/tutorials/neo.ipynb‎

Lines changed: 12 additions & 26 deletions
Large diffs are not rendered by default.

‎docs/tutorials/on_off_ctrl.ipynb‎

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

‎docs/tutorials/optimal_ctrl.ipynb‎

Lines changed: 621 additions & 88 deletions
Large diffs are not rendered by default.

‎docs/tutorials/optogenetics.ipynb‎

Lines changed: 15 additions & 15 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)