Fix spiking functionality and sample period handling

[kjohnsen]

• Identify the exact @copilot review comment in PR Fix spiking functionality and sample period handling #70 and confirm it is actionable
• Apply only the requested/suggested code change for that single comment
• Run targeted validation for the touched area
• Run final PR validation checks
• Reply on the addressed review comment with the fixing commit hash

[gitnotebooks]

Review these changes at https://app.gitnotebooks.com/siplab-gt/cleo/pull/70

[Copilot]

Pull request overview

This PR fixes two issues in Cleo’s electrophysiology signals: (1) spiking signals now behave correctly when a probe records zero neurons, and (2) RWSLFPSignalFromPSCs can correctly receive (or enforce) a sampling period, including via injection kwargs.

Changes:

• Initialize spiking signal internal state so get_state() works even when no neurons meet recording criteria.
• Plumb sample_period (and other injection kwargs) through to RWSLFPSignalFromPSCs buffer-length computation and raise a more specific error when missing.
• Add/extend tests covering the “no neurons recorded” spiking case and the missing/explicit sampling period behavior for PSC-based RWSLFP.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
tests/ephys/test_spiking.py	Adds a regression test ensuring spiking signals stay empty/consistent when no neurons are recordable.
tests/ephys/test_lfp.py	Updates test helper to pass injection kwargs and adds coverage for missing sample_period error path.
cleo/ephys/spiking.py	Ensures spiking signals initialize required internal fields even when zero neurons are recorded; handles None return in SortedSpiking.
cleo/ephys/lfp.py	Passes injection kwargs into buffer-length computation and raises RuntimeError when sampling period cannot be determined.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Fixed in commit 1774111.