fix(meal): reject omitted rate-only insulin delivery

Author: siriushex

AI_NOTES.md

@@ -1,3 +1,20 @@
+# Meal Research Interval Inventory - 2026-10-23
+
+- Main bdf7b070 has all three successful Verify jobs in run 39918968049.
+- Four failing-first tests reproduced omitted rate-only basal, missing fields
+  on delivery-only types, old/duplicate intervals and a falsely evaluated meal
+  assessment. Original 52-test run: four expected failures, no other failures.
+- Admit such records to the inventory audit, not the model: unsupported interval
+  exposure blocks assessment and direct simulation/forward projection. Preserve
+  unrelated food/exercise duration and explicit null-field behavior. No physical
+  delivery, upstream completeness or safe meal-wait interval is inferred.
+- All 124 focused tests passed. Frozen full test/lint/compile/assemble passed
+  in 8m15s: 6805 passed, six existing skips, zero errors; real stock SDK TLS
+  took 2.446s. Lint: zero errors, 382 existing warnings/eight hints. All 1431
+  source hashes stayed unchanged and all 7176 application classes were retained
+  in the 40,670,992-byte local APK. Exact-source Verify remains a separate gate.
+- No AAPS, schema, phone, server, dose, target, alarm or live countdown change.
+
 # Insulin History Release 0.1.12 - 2026-10-23
 
 - PR27 passed all six exact-source checks and automatic review. Main merge

android-app/app/src/main/kotlin/io/aaps/copilot/domain/predict/HybridPredictionEngine.kt

@@ -1560,11 +1560,14 @@ class HybridPredictionEngine(
         return type.contains("bolus") || type.contains("correction") || type == "insulin"
     }
 
+    // Rate-only intervals and pump state records cannot establish absence of insulin.
     private fun mealRecordMayContainInsulin(event: TherapyEvent): Boolean = eventCanCarryInsulin(event) ||
+        normalize(event.type).replace("_", "") in setOf("basal", "tempbasal", "temporarybasal",
+            "basalrate", "extendedbolus", "combobolus", "pumpsuspend", "pumpresume") ||
         event.payload.any { (key, value) ->
             when (key.lowercase(Locale.US).filter(Char::isLetterOrDigit)) {
                 "bolusunits", "insulinunits", "insulin", "enteredinsulin" -> true
-                "extendedemulated" -> value.trim() != "null"
+                "extendedemulated", "rate", "absolute", "percent", "relative" -> value.trim() != "null"
                 "isbasalinsulin", "isemulatingtempbasal" -> value.trim().uppercase(Locale.US) !in setOf("FALSE", "0")
                 else -> false
             }

android-app/app/src/test/kotlin/io/aaps/copilot/domain/meal/MealTimingResearchAssessmentTest.kt

@@ -59,6 +59,31 @@ class MealTimingResearchAssessmentTest {
         }
     }
 
+    @Test fun rateOnlyDeliveryBlocksResearchAssessmentAndBothDirectSimulationPaths() = runBlocking {
+        for ((type, fields) in listOf("temp_basal" to mapOf("rate" to "1", "duration" to "30"),
+            "treatment" to mapOf("percent" to "-100", "duration" to "30"),
+            "pump_suspend" to emptyMap())) {
+            val context = context(extraEvents = listOf(TherapyEvent(now - 60_000L, type, fields,
+                sourceRowId = "interval-delivery")))
+            val result = MealTimingResearchEvaluator().evaluate(context, belief(), episode, telemetry(), 180)
+            assertEquals(MealTimingResearchStatus.INSULIN_INVENTORY_UNAVAILABLE, result.status)
+            assertNull(result.batch)
+            assertTrue(result.noFoodPaths.isEmpty())
+            assertNull(result.recommendedStartAtMs)
+            assertFalse(result.notificationAllowed)
+            assertFalse(result.therapyAllowed)
+            try {
+                MealScenarioSimulator().simulate(context, belief(), 180)
+                fail("Unaccounted interval delivery returned a scenario batch")
+            } catch (error: IllegalArgumentException) {
+                assertEquals("Meal research insulin inventory is unsupported", error.message)
+            }
+            val food = MealAbsorptionProjection.project(now, now, 35.0, MealAbsorptionProfile.MIXED, 120, 180)
+            assertThrows(IllegalArgumentException::class.java) { context.forwardForecast("12", food, 180) }
+            assertEquals(context.baselineForecasts, context.newEngine().predict(context.glucose, context.therapy))
+        }
+    }
+
     @Test fun hiddenOrNonInstantInsulinStopsAssessmentWithoutChangingLiveForecast() = runBlocking {
         for ((type, fields) in listOf("treatment" to mapOf("insulin" to "1"),
             "bolus" to mapOf("units" to "1", "duration" to "60"),

android-app/app/src/test/kotlin/io/aaps/copilot/domain/predict/MealInsulinProjectionTest.kt

@@ -7,6 +7,47 @@ import org.junit.Assert.*
 import org.junit.Test
 
 class MealInsulinProjectionTest {
+    @Test fun intervalDeliveryWithoutDoseUnitsCannotDisappearFromInventory() {
+        for (type in listOf("temp_basal", "treatment", "carbs", "unknown")) {
+            for (field in listOf("rate", "absolute", "percent", "relative")) {
+                for (value in listOf("0", "1.5", "-100", "NaN", "unknown")) {
+                    val event = TherapyEvent(now - 60_000L, type,
+                        mapOf(field to value, "duration" to "30"), sourceRowId = "interval-1")
+                    val result = engine().projectMealTimingInsulin(glucose, listOf(event), 60)
+                    assertEquals("$type/$field/$value", 1, result.unsupportedEventCount)
+                    assertTrue(result.unsupportedReasons.contains(MealInsulinInventoryIssue.NON_INSTANT_OR_AMBIGUOUS_DELIVERY))
+                    assertThrows(IllegalArgumentException::class.java) { result.requireUsableInventory() }
+                }
+            }
+        }
+    }
+
+    @Test fun deliveryOnlyTypesRequireEvidenceEvenWhenFieldsAreMissing() {
+        for (type in listOf("basal", "Temp Basal", "tempBasal", "temporary_basal", "basal_rate",
+            "Extended Bolus", "combo_bolus", "pump_suspend", "pump_resume")) {
+            val event = TherapyEvent(now - 60_000L, type, emptyMap(), sourceRowId = "interval-1")
+            assertEquals(type, 1, engine().projectMealTimingInsulin(glucose, listOf(event), 60).unsupportedEventCount)
+        }
+    }
+
+    @Test fun oldOrDuplicateRateOnlyRecordsRemainUnsupportedRatherThanExpiredOrAbsent() {
+        val old = TherapyEvent(now - 48 * 60 * 60_000L, "treatment",
+            mapOf("absolute" to "0", "duration" to "2880"), sourceRowId = "interval-1")
+        val result = engine().projectMealTimingInsulin(glucose, listOf(old, old), 60)
+        assertEquals(2, result.unsupportedEventCount)
+        assertTrue(result.unsupportedReasons.contains(MealInsulinInventoryIssue.DUPLICATE_OR_EMPTY_IDENTITY))
+    }
+
+    @Test fun nullIntervalFieldsAndOrdinaryFoodOrExerciseDurationDoNotInventInsulin() {
+        for (type in listOf("carbs", "exercise", "note")) {
+            val event = TherapyEvent(now, type, mapOf("duration" to "30", "units" to "g",
+                "rate" to "null", "absolute" to "null", "percent" to "null", "relative" to "null"))
+            val result = engine().projectMealTimingInsulin(glucose, listOf(event), 60)
+            assertEquals(0, result.unsupportedEventCount)
+            assertEquals(0, result.modeledEventCount)
+        }
+    }
+
     @Test fun insulinPayloadCannotDisappearBehindAnUnrecognizedEventType() {
         for (type in listOf("treatment", "meal", "note", "unknown")) {
             val event = bolus.copy(type = type, payload = mapOf("insulin" to "2"))

docs/MEAL_TIMING_EVIDENCE.md

@@ -51,6 +51,17 @@ worker, server route, database schema, model execution or therapy writer is adde
 
 ## Requirements For A Recommendation
 
+The research inventory must inspect interval evidence even without a dose-units
+field. Rate-only absolute/percentage basal and explicit basal/suspend/resume
+records cannot disappear from the bolus-only forecast. Unrecognized forms,
+zero-rate suspension, malformed rates and old intervals with unknown support
+remain unsupported. No duration or delivery is invented from those fields.
+Assessment, direct simulation and direct forward projection all refuse such an
+inventory, preserving the separate live prediction. Ordinary food/exercise
+duration and null interval fields do not create insulin records.
+This refusal closes an omission, not source/pump completeness: independent
+upstream coverage and clinical validation below remain necessary.
+
 1. Capture explicit meal intent, actual meal start and confirmed bolus delivery
    linkage separately. An entered timestamp, positive IOB, SMB or correction
    bolus must not silently become proof of a planned meal.

docs/PLAN.md

@@ -1,5 +1,17 @@
 # PLAN
 
+## Meal Research Interval Inventory (2026-10-23)
+
+- [x] Confirm main bdf7b070 CI39918968049 passed all three jobs.
+- [x] Reproduce four rate-only/missing-form/old-record and assessment omissions.
+- [x] Audit interval fields and delivery-only event types without inventing doses.
+- [x] All 124 focused tests passed with no failures or skips.
+- [x] Frozen full Android quality: 6805 passed/six existing skips, real SDK TLS,
+      zero lint errors and preserved application classes; no source drift.
+- [ ] Publish reviewed source and verify exact-head CI before integration.
+- No source/pump completeness or meal recommendation admission follows from
+  this guard. Independent coverage and prospective validation remain required.
+
 ## Insulin History Release 0.1.12 (2026-10-23)
 
 - [x] PR27 passed all six checks and review; merge c2cc714c has the identical