Repository navigation
Reject hidden native insulin delivery forms - #27
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A retained treatment could contain basal or extended insulin fields but be classified as food or an unrelated event, yielding an empty or partial insulin inventory. Audit explicit delivery evidence before native branch precedence and reject conflicting forms. Legitimate bolus, temporary-basal and single-child extended emulation remain supported; transport retention and live therapy behavior stay unchanged.
Six failing-first regressions cover hidden forms plus accepted wire data through Room, cache refresh and reopen. All 164 focused tests and 6800 full Android tests passed (six existing skips), with real pristine RC1 SDK TLS, zero lint errors, APK assembly and application-class retention. Main fa6f22b passed all three CI jobs. Feature CI must pass before integration.
This does not attest complete source/pump coverage or enable recommended meal waiting times. No phone, AAPS or server deployment.