Repository navigation
Keep native insulin uploads pending when historical profile is missing - #28
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on PR #27 (same reviewed source base). This change adds a separately verified, minimal patch for pinned AAPS 4.0.0-rc1; it does not modify the installed AAPS or Copilot therapy behavior.
The stock interval uploader can advance a synchronization cursor without a network request when the historical profile is unavailable. Return false for missing-profile CREATE/UPDATE and retain the extended-bolus cursor for normal retry. Preserve imported and identifier-only skip rules. Do not substitute today's profile or reset synchronization IDs.
Three failures reproduced before the fix. The combined native patch recipe passed 485 tests, including 87 uploader tests and six new cases, with no failures/skips. Unchanged suites reused verified Gradle outputs. All 22 recipe/JSON-isolation checks passed; the pinned upstream checkout was restored clean. Tests cover ordinary extended bolus, emulated basal, temporary basal, invalidation, HTTP failure and later successful retry. Exact-head CI is required before integration.
Limitation: an irretrievable historical profile holds that collection. This patch neither recovers previously skipped history nor establishes destination-bound completeness or physical pump delivery. The recommended meal-time gate remains closed. No phone/server deployment, APK publication or therapy change.