Skip to content

Require valid native insulin history upload receipts - #32

Merged
siriushex merged 1 commit into
mainfrom
codex/insulin-upload-receipts-20261023
Oct 23, 2026
Merged

siriushex merged 1 commit into
mainfrom
codex/insulin-upload-receipts-20261023

Conversation

@siriushex

Copy link
Copy Markdown
Owner

Change

Extend the existing minimal pinned AAPS RC1 uploader patch. Bolus, temporary basal and extended/emulated bolus uploads must receive a valid CREATE identity or an unchanged UPDATE identity before their history cursor can advance. Refused/missing/malformed receipts, including repeated valid-record 404, cannot become success. Successful native identifier-less UPDATE and idempotent deletion 404 remain supported. Other treatment error policies are unchanged.

No fallback CREATE, new retry loop, endpoint, schema, credential or pump command is added. A refused record deliberately holds its collection until corrected; it is not silently skipped even in error-ignore mode.

Evidence

  • Six intended native assertion failures reproduced before the fix.
  • Both complete uploader suites: 93 passed, including recreated uploader, rejection, later success and invalidation cases.
  • Combined pinned native recipe: 491 passed, no errors/failures/skips; exact pristine upstream state restored afterward.
  • 16 recipe ownership tests passed. Initial JSON-isolation invocation lacked AAPS_RC1_DIR; after supplying the required environment, all six isolation tests passed. No check skipped.
  • Full local Copilot test/lint/compile/assemble commands passed with unchanged Android tasks up-to-date. Retained results: 6815 passed, six existing skips, zero lint errors. This is cached validation, not a new 6815-test execution.
  • All 1442 frozen source hashes unchanged. Exact-source CI is a separate gate.

Limits

This prevents future transport gaps in the candidate patch; it does not recover earlier omissions or attest initial destination, pump history, clock epochs or clinically safe meal timing. Preferences and HTTP peer are test doubles; uploader recreation is not a real phone process-death test. No phone/AAPS APK/server/therapy changes, no recommendation enabled and no APK publication. Main integration only after successful exact-source CI/review.

@siriushex
siriushex merged commit b1be8e6 into main Oct 23, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant