Repository navigation
Require valid native insulin history upload receipts - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Extend the existing minimal pinned AAPS RC1 uploader patch. Bolus, temporary basal and extended/emulated bolus uploads must receive a valid CREATE identity or an unchanged UPDATE identity before their history cursor can advance. Refused/missing/malformed receipts, including repeated valid-record 404, cannot become success. Successful native identifier-less UPDATE and idempotent deletion 404 remain supported. Other treatment error policies are unchanged.
No fallback CREATE, new retry loop, endpoint, schema, credential or pump command is added. A refused record deliberately holds its collection until corrected; it is not silently skipped even in error-ignore mode.
Evidence
Limits
This prevents future transport gaps in the candidate patch; it does not recover earlier omissions or attest initial destination, pump history, clock epochs or clinically safe meal timing. Preferences and HTTP peer are test doubles; uploader recreation is not a real phone process-death test. No phone/AAPS APK/server/therapy changes, no recommendation enabled and no APK publication. Main integration only after successful exact-source CI/review.