You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once #2364 ships, the Editor widget skips do_shortcode() whenever SITEORIGIN_PANELS_POST_CONTENT_RENDER is set. That guard is unconditional. It does not consult Page Builder's siteorigin_panels_post_content_keep_shortcodes filter, so a site that returns false from that filter to opt back into baked shortcode output gets it for core Text widgets but not for Editor widgets.
Save a page with an Editor widget containing a shortcode.
Inspect post_content.
Expected: the shortcode output is baked into the mirror, matching the filter's contract and the core Text widget's behaviour.
Actual: the raw shortcode is kept. The same page with a core Text widget bakes correctly.
Verified locally against both fix branches: Text widget honours the filter, Editor widget does not.
Suggested fix
In widgets/editor/editor.php, when SITEORIGIN_PANELS_POST_CONTENT_RENDER is set, run do_shortcode() anyway if apply_filters( 'siteorigin_panels_post_content_keep_shortcodes', true ) returns false. Keep the legacy SITEORIGIN_PANELS_CACHE_RENDER guard as is.
Low impact: the filter is new and opt-in, and the default behaviour is correct in both plugins.
Summary
Once #2364 ships, the Editor widget skips
do_shortcode()wheneverSITEORIGIN_PANELS_POST_CONTENT_RENDERis set. That guard is unconditional. It does not consult Page Builder'ssiteorigin_panels_post_content_keep_shortcodesfilter, so a site that returnsfalsefrom that filter to opt back into baked shortcode output gets it for core Text widgets but not for Editor widgets.Steps to reproduce
add_filter( 'siteorigin_panels_post_content_keep_shortcodes', '__return_false' );post_content.Expected: the shortcode output is baked into the mirror, matching the filter's contract and the core Text widget's behaviour.
Actual: the raw shortcode is kept. The same page with a core Text widget bakes correctly.
Verified locally against both fix branches: Text widget honours the filter, Editor widget does not.
Suggested fix
In
widgets/editor/editor.php, whenSITEORIGIN_PANELS_POST_CONTENT_RENDERis set, rundo_shortcode()anyway ifapply_filters( 'siteorigin_panels_post_content_keep_shortcodes', true )returnsfalse. Keep the legacySITEORIGIN_PANELS_CACHE_RENDERguard as is.Low impact: the filter is new and opt-in, and the default behaviour is correct in both plugins.