Skip to content

Commit d0f1417

Browse files
dblockCopilot
andcommitted
Remove obsolete JSON version pin from test bundle
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 7ed5d09 commit d0f1417

3 files changed

Lines changed: 1 addition & 2 deletions

File tree

‎AGENTS.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ Read [CONTRIBUTING.md](CONTRIBUTING.md) first for setup, tests, lint, changelog,
1010
- Do not edit the API-reference submodule or include existing submodule changes unless requested.
1111
- The API update task pulls the latest reference and can generate unrelated changes. Verify the patch against both the latest and pinned reference; keep unrelated generated updates out of a focused PR. Custom endpoint specs are handwritten despite their location under `endpoints/`.
1212
- Do not suppress environment warnings in application code or tests. Report local validation limitations explicitly; CLI specs compare subprocess output and can fail when Bundler emits unrelated warnings.
13-
- Keep the test bundle on JSON below 3 until Faraday's JSON middleware supports JSON 3's keyword-only parse options.

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
### 3.3.0 (Next)
22

3+
* Remove the test-bundle JSON version pin; Faraday 2.14.4 supports JSON 3 - [@dblock](https://github.com/dblock).
34
* [#603](https://github.com/slack-ruby/slack-ruby-client/pull/603): Enforce consistent exception messages with rubocop-exception_messages and run lint separately from the test matrix - [@dblock](https://github.com/dblock).
45
* [#602](https://github.com/slack-ruby/slack-ruby-client/pull/602): Make gli an optional dependency; only the `slack` command-line client needs it - [@corsonknowles](https://github.com/corsonknowles).
56
* [#599](https://github.com/slack-ruby/slack-ruby-client/pull/599): Set a default filename in `files_upload` so Slack displays image previews correctly when none is specified - [@ts-3156](https://github.com/ts-3156), [@dblock](https://github.com/dblock).

‎Gemfile‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ group :test do
1313
gem 'erubis'
1414
gem 'faraday-typhoeus'
1515
gem 'gli'
16-
gem 'json', '< 3' # Faraday's JSON middleware passes options as a positional hash.
1716
gem 'json-schema'
1817
gem 'mutex_m'
1918
gem 'racc'

0 commit comments

Comments
 (0)