Skip to content

feat(methods): add apps.icon.set method example - #397

Merged
zimeg merged 3 commits into
mainfrom
zimeg-feat-apps-icon-set-example
Nov 20, 2026
Merged

zimeg merged 3 commits into
mainfrom
zimeg-feat-apps-icon-set-example

Conversation

@zimeg

@zimeg zimeg commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds a method example for apps.icon.set in methods/src/apps/icon/apps_icon_set.py, and lists it in methods/README.md.

  • The arguments follow the order of the reference page. It has no example values, so app_id and url are placeholders.
  • This layer adds the apps/icon/ app scaffold. Its app_configurations:write scope belongs to app configuration tokens, which a manifest can't request (apps.manifest.validate returns illegal_user_scopes), so the manifest lists no scopes, like blocks/.

This is the only pull request in the apps.icon stack of method examples, so it's based on main. It's in the B7 app settings batch.

  1. feat(methods): add apps.icon.set method example #397 apps.icon.set 👈 this pull request

Dependency

This depends on slackapi/python-slack-sdk#2058, which adds apps.icon.set to slack_sdk. It shipped in slack_sdk 3.48.0, which methods/pyproject.toml now pins.

Testing

With slackapi/python-slack-sdk#2058 installed locally:

  1. cd methods/src/apps/icon && slack install --environment local, then export SLACK_TOKEN=... with an app configuration token.
  2. Set app_id to an app you collaborate on and url to a publicly hosted square image of at least 512px, then slack run apps_icon_set.py and confirm ok and the new icon on the app settings page.

Live run: the placeholder app_id returns invalid_app. With a real app ID, url and file each changed the icon the app's bot shows in bots.info (see the SDK pull request). Each example was run live in a developer workspace with a local slack_sdk build that has every method from these stacks.

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg and others added 2 commits November 20, 2026 02:04
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
… token type

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg marked this pull request as ready for review November 20, 2026 10:10
@zimeg
zimeg requested a review from a team as a code owner November 20, 2026 10:10

@cchensh cchensh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The call matches the released SDK (method, argument names and types), the structure matches the sibling examples, and CI is green.

@zimeg

zimeg commented Nov 20, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind review @cchensh! Happy to have the app settings methods in the python examples 🐍

@zimeg
zimeg merged commit 5b970ea into main Nov 20, 2026
16 checks passed
@zimeg
zimeg deleted the zimeg-feat-apps-icon-set-example branch November 20, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants