Skip to content

chore: add ruff and pytest to pyproject.toml - #8

Closed
srtaalej wants to merge 4 commits into
mainfrom
add-pyproject-toml
Closed

srtaalej wants to merge 4 commits into
mainfrom
add-pyproject-toml

Conversation

@srtaalej

Copy link
Copy Markdown

Summary

  • Adds pyproject.toml with ruff and pytest configuration
  • Matches the pattern used in bolt-python-starter-template

Test plan

  • Verify ruff check and ruff format respect the config

@srtaalej
srtaalej requested a review from a team as a code owner May 12, 2026 19:29
@srtaalej srtaalej self-assigned this May 12, 2026
@srtaalej srtaalej added enhancement New feature or request dependencies labels May 12, 2026
@mwbrooks mwbrooks changed the title chore: add pyproject.toml chore: add ruff and pytest to pyproject.toml Oct 20, 2026
@mwbrooks

Copy link
Copy Markdown
Member

Heads up @srtaalej: PR#17 just added a pyproject.toml to main, so I've updated this PR to bring in those changes. I've also updated the title to focus on your ruff and pytest settings.

@srtaalej
srtaalej requested a review from mwbrooks October 26, 2026 06:35

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Ignore these idea if it's not ideal direction but I lean toward closing this PR?

Both ruff and pytest aren't installed as dependencies or shown on the Creating an app guide this sample is meant to model. I'm open to revisiting this but for now I don't think we should extend this or the Bolt for JS "getting started app" sample with such.

@srtaalej srtaalej closed this Nov 9, 2026
@zimeg
zimeg deleted the add-pyproject-toml branch November 9, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants