Repository navigation
ci: open a pull request when the agent skills update - #63
Conversation
WilliamBergamin
left a comment
There was a problem hiding this comment.
🙏 @mwbrooks thanks for bringing the skills workflow to the Python search template, and for keeping the token off the update step.
Two blocking comments: update PRs won't get the required CI checks, and skills@1 floats in a job that can write. The loop simplification is optional 🙏
| git commit -m "chore: update agent skills" | ||
| git push --force origin agent-skills | ||
| if [ "$(gh pr view agent-skills --json state --jq .state 2>/dev/null)" != "OPEN" ]; then | ||
| gh pr create --head agent-skills --title "chore: update agent skills" --body "Updates the agent skills in \`skills-lock.json\` to the latest versions." |
There was a problem hiding this comment.
✅ issue (blocking): main here requires the test and lint checks from ci.yml, but a PR pushed and opened with the default GITHUB_TOKEN never triggers ci.yml. Each update PR would wait on them until someone re-triggers it. Could we use an app token from actions/create-github-app-token for the push and gh pr create?
There was a problem hiding this comment.
note: The update PRs do start CI here. GitHub holds the runs as action_required, since github-actions[bot] isn't a collaborator, and MIC approves them before merging. We'll follow up on a way to run them without a manual approval. The pilot's first update PR ran and passed this way: slack-samples/bolt-js-starter-template#190
| - name: Update the skills in each skills-lock.json | ||
| run: | | ||
| while IFS= read -r lock; do | ||
| (cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes) |
There was a problem hiding this comment.
📦 issue (blocking): skills@1 floats to every new 1.x and runs in a job that can write. A bad release could drop a .git/hooks file or a $GITHUB_PATH shim that the next step runs with GH_TOKEN. Could we pin an exact version?
| (cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes) | |
| (cd "$(dirname "$lock")" && npx --yes skills@1.9.0 update --project --yes) |
There was a problem hiding this comment.
note: Keeping skills@1 for now, per our DM. The token stays off the npx step, and a pin would mostly add version bumps to chase across 49 samples.
| run: | | ||
| while IFS= read -r lock; do | ||
| (cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes) | ||
| done < <(find . -name skills-lock.json -not -path "*/node_modules/*") |
There was a problem hiding this comment.
🪓 suggestion (non-blocking): this repo has one skills-lock.json at the root, so the find loop and glob pathspecs could be a single npx command and git add -- skills-lock.json .agents/skills .claude/skills.
| run: | | |
| while IFS= read -r lock; do | |
| (cd "$(dirname "$lock")" && npx --yes skills@1 update --project --yes) | |
| done < <(find . -name skills-lock.json -not -path "*/node_modules/*") | |
| npx --yes skills@1.9.0 update --project --yes |
There was a problem hiding this comment.
note: I'd like to keep one workflow shape across all 49 samples, so a fix lands the same way everywhere. Here the loop just runs once.
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false |
There was a problem hiding this comment.
💯 praise: persist-credentials: false with GH_TOKEN only on the push step keeps the token away from the update step.
WilliamBergamin
left a comment
There was a problem hiding this comment.
✅ @mwbrooks thanks for the follow-up. The pilot's update PR shows CI does run once its held runs are approved, and keeping skills@1 with the token off the npx step works for us. Nothing blocking now 🚀
The blocking concerns are resolved; see the latest review.
|
Thanks @zimeg for the review, and @WilliamBergamin for the careful look at the token and the |
Summary
This pull request keeps the pre-installed agent skills current for developers who build from this sample, so their coding agent follows the latest Slack guidance without anyone running
npx skills updateby hand.npx skills@1 update --project --yesand opens onechore: update agent skillspull request when the skills change..agents/skills,.claude/skills, andskills-lock.json, becauseskillsalso writes.grok/and.kiro/folders on update.Testing
Notes
mainofslackapi/slack-skills-plugin, the same asnpx skills update.