Skip to content

fix(model): add agent prompt and visibility fields to the button block element - #1666

Merged
mwbrooks merged 3 commits into
mainfrom
mwbrooks-button-agent-prompt-fields
Oct 29, 2026
Merged

mwbrooks merged 3 commits into
mainfrom
mwbrooks-button-agent-prompt-fields

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

This pull request lets Java and Kotlin developers set the agent_prompt, agent_prompt_display, and visible_to_user_ids fields on a button block element. Until now, ButtonElement had no fields for these documented options, so a button built with the model could not send them.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@mwbrooks mwbrooks added this to the 1.52.1 milestone Oct 28, 2026
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-model project:slack-api-model lang:kotlin semver:patch labels Oct 28, 2026
@mwbrooks mwbrooks self-assigned this Oct 28, 2026
@mwbrooks
mwbrooks marked this pull request as ready for review October 28, 2026 17:09
@mwbrooks
mwbrooks requested a review from a team as a code owner October 28, 2026 17:09
@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.19%. Comparing base (71b89d5) to head (c95a286).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...in_extension/block/element/ButtonElementBuilder.kt 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1666      +/-   ##
============================================
- Coverage     73.20%   73.19%   -0.01%     
- Complexity     4645     4648       +3     
============================================
  Files           486      486              
  Lines         14642    14649       +7     
  Branches       1524     1524              
============================================
+ Hits          10718    10723       +5     
- Misses         3019     3020       +1     
- Partials        905      906       +1     
Flag Coverage Δ
jdk-14 73.19% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕ 👹 @mwbrooks Another great change to land! I appreciate kotlin kept standard with this PR so please merge when the time is right.

@mwbrooks
mwbrooks requested a review from a team October 28, 2026 17:19
@mwbrooks
mwbrooks merged commit ff18e20 into main Oct 29, 2026
7 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-button-agent-prompt-fields branch October 29, 2026 17:48
@mwbrooks

Copy link
Copy Markdown
Member Author

Thanks @zimeg for the quick review! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented lang:kotlin project:slack-api-model project:slack-api-model semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants