Repository navigation
fix(model): add is_file to conversation - #1681
Merged
Merged
Conversation
Slack's conversation object includes is_file, which it sets on the hidden conversation behind a canvas. ChannelCreatedEvent.Channel already maps it, but Conversation (conversations.info / conversations.list) drops it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the contribution! Before we can merge this, we need @rasharab to sign the Salesforce Inc. Contributor License Agreement. |
Contributor
Author
|
@mwbrooks Is this all right with you guys? |
mwbrooks
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1681 +/- ##
============================================
+ Coverage 73.72% 73.75% +0.02%
- Complexity 4678 4679 +1
============================================
Files 487 487
Lines 14669 14669
Branches 1528 1528
============================================
+ Hits 10815 10819 +4
+ Misses 2944 2941 -3
+ Partials 910 909 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
mwbrooks
approved these changes
Nov 11, 2026
| @SerializedName("is_non_threadable") | ||
| private boolean isNonThreadable; | ||
| @SerializedName("is_file") | ||
| private boolean isFile; |
Member
There was a problem hiding this comment.
praise: Thanks for adding is_file here! It matches how ChannelCreatedEvent.Channel already maps it, so canvas conversations are easy to spot now.
mwbrooks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack's conversation object includes
is_file("Whether this is a file channel"). Slack sets it on the hidden conversation it creates behind a canvas.ChannelCreatedEvent.Channelalready maps it, butConversation, whichconversations.infoandconversations.listresponses parse into, drops it. Apps then can't tell a canvas conversation from a real channel without parsingname_normalized.This adds
isFiletoConversation, alongsideisThreadOnly/isNonThreadable, adds the key to theconversations.infoandconversations.listsamples, and adds a parsing test.Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.