Skip to content

fix(model): add is_file to conversation #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 2 commits into from
Nov 11, 2026
+16 −0
Merged

fix(model): add is_file to conversation #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dc6e65
Add is_file to Conversation
rasharab Nov 10, 2026
aaff76e
Re-run CLA check
rasharab Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions json-logs/samples/api/conversations.info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"is_read_only": false,
"is_thread_only": false,
"is_non_threadable": false,
"is_file": false,
"internal_team_ids": [
"T00000000"
],
Expand Down
1 change: 1 addition & 0 deletions json-logs/samples/api/conversations.list.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"is_mpim": false,
"is_private": false,
"is_general": false,
"is_file": false,
"unlinked": 12345,
"name_normalized": "",
"is_shared": false,
Expand Down
12 changes: 12 additions & 0 deletions slack-api-client/src/test/java/test_locally/api/model/ConversationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@

import com.slack.api.methods.response.conversations.ConversationsInfoResponse;
import com.slack.api.methods.response.conversations.ConversationsListResponse;
import com.slack.api.util.json.GsonFactory;
import org.junit.Test;

import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;

public class ConversationTest implements Verifier {

@Test
Expand All @@ -16,4 +20,12 @@ public void parseConversationsListResponse() throws Exception {
verifyParsing("conversations.list", ConversationsListResponse.class);
}

@Test
public void parseFileConversation() {
String json = "{\"ok\":true,\"channel\":{\"id\":\"C0123456789\",\"is_channel\":true,\"is_private\":true,"
+ "\"is_file\":true,\"is_thread_only\":true,\"name_normalized\":\"FC:F0123456789:Project notes\"}}";
ConversationsInfoResponse resp = GsonFactory.createSnakeCase().fromJson(json, ConversationsInfoResponse.class);
assertThat(resp.getChannel().isFile(), is(true));
}

}
2 changes: 2 additions & 0 deletions slack-api-model/src/main/java/com/slack/api/model/Conversation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ public class Conversation {
private boolean isThreadOnly;
@SerializedName("is_non_threadable")
private boolean isNonThreadable;
@SerializedName("is_file")
private boolean isFile;

@mwbrooks mwbrooks Nov 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for adding is_file here! It matches how ChannelCreatedEvent.Channel already maps it, so canvas conversations are easy to spot now.

@SerializedName("is_shared")
private boolean isShared;
@SerializedName("is_ext_shared")
Expand Down
Loading