Repository navigation
fix(web-api): add broadcast_delete argument to chat.delete - #2816
Open
kai-at-momos wants to merge 1 commit into
Open
kai-at-momos wants to merge 1 commit into
kai-at-momos wants to merge 1 commit into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @kai-at-momos to sign the Salesforce Inc. Contributor License Agreement. |
🦋 Changeset detectedLatest commit: a045a6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kai-at-momos
force-pushed
the
feat/chat-delete-broadcast-delete
branch
from
November 5, 2026 16:37
5151504 to
a045a6f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the optional
broadcast_deleteargument toChatDeleteArguments.chat.deletewithbroadcast_delete: trueon a thread reply that was also sent to the channel (subtype: thread_broadcast) removes it from the channel only. The reply stays in its thread with the samets. This is what the Slack client sends for "Remove from channel", and it works with a bot token too.It is the only way to reverse
reply_broadcast.chat.updatewithreply_broadcast: falsereturnsok: trueand changes nothing.Verified against the live API with a bot token:
chat.postMessagewiththread_ts+reply_broadcast: true->thread_broadcastinconversations.historychat.deletewithbroadcast_delete: true->ok: trueconversations.historyand still inconversations.replieswith the samets, now a plain replyThe argument is not on the
chat.deletereference page yet, so the JSDoc describes the observed behaviour.Changes:
packages/web-api/src/types/request/chat.ts:broadcast_delete?: booleanonChatDeleteArgumentspackages/web-api/test/types/methods/chat.test-d.ts: happy-path type test@slack/web-apipatchtsdreports 6 errors onmainbefore and after this change (files.upload,rtm.start), none inchat.Related: #2815
Requirements