Repository navigation
build: run every test file in oauth and cli-test - #2818
Conversation
The src/**/*.test.ts glob is expanded by the shell, and neither bash 3.2 nor dash supports globstar, so it only matched files one directory deep. oauth ran 16 of 76 tests and cli-test 28 of 108. List each depth explicitly, since Node 20 cannot expand globs passed to --test, and run test:coverage through bash like test so both expand the same way. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
+ Coverage 89.35% 93.79% +4.43%
==========================================
Files 65 66 +1
Lines 10562 10571 +9
Branches 489 611 +122
==========================================
+ Hits 9438 9915 +477
+ Misses 1092 619 -473
- Partials 32 37 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
added
tests
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Thanks @WilliamBergamin! Great catch, 16 of 76 tests is a sneaky one to miss.
Summary
This pull request makes the
@slack/oauthand@slack/cli-testtest scripts run every test file.**, sosrc/**/*.test.tsonly matched files one folder deep.oauthran 16 of 76 tests andcli-testran 28 of 108.src/*.test.ts src/*/*.test.ts).Testing
Run
npm test --workspace=packages/oauthandnpm test --workspace=packages/cli-test. They report 76 and 108 tests (16 and 28 onmain).Requirements
🤖 Generated with Claude Code