Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 234c663 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2825 +/- ##
==========================================
- Coverage 93.89% 93.82% -0.08%
==========================================
Files 66 66
Lines 10571 10571
Branches 611 611
==========================================
- Hits 9926 9918 -8
- Misses 609 617 +8
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request lets a checkboxes or radio buttons option use a
mrkdwndescription, as the option object and checkboxes element docs show. Until now, the docs payload (aplain_textoptiontextwith amrkdwndescription) failed to compile.Closes #1765.
MrkdwnOption(used byCheckboxesandRadioButtons) now takes aplain_textormrkdwntextanddescription.PlainTextOption(used by overflow, select, and multi-select menus) keeps aplain_text-onlydescription, as the docs require.tsdcases: checkboxes and radio buttons accept amrkdwndescription, and overflow and static select reject one.descriptionbut keptMrkdwnOption.textasmrkdwn-only, so the docs payload still failed to compile there.Testing
npm test --workspace=packages/typesand confirmtsdpasses.packages/types/src/block-kit/composition-objects.tsand confirm the new checkboxes and radio buttons cases fail.Requirements
🤖 Generated with Claude Code