Skip to content

Commit b610b2d

Browse files
committed
fix mypy issues
1 parent 53b1353 commit b610b2d

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎integration_tests/web/test_message_metadata.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66

77
from integration_tests.env_variable_names import SLACK_SDK_TEST_BOT_TOKEN
88
from slack_sdk.models.metadata import (
9-
Metadata, EventAndEntityMetadata, EntityMetadata, EntityType, ExternalRef,
9+
Metadata, EventAndEntityMetadata, EntityMetadata, ExternalRef,
1010
EntityPayload, EntityAttributes, EntityTitle, TaskEntityFields, EntityStringField,
1111
EntityTitle, EntityAttributes, EntityFullSizePreview,
1212
TaskEntityFields, EntityTypedField, EntityStringField, EntityTimestampField,
1313
EntityEditSupport, EntityEditTextConfig, EntityCustomField, EntityUserIDField,
14-
EntityIconField, ExternalRef as CustomExternalRef
14+
EntityIconField, ExternalRef as CustomExternalRef, EntityArrayItemField
1515
)
1616
from slack_sdk.web import WebClient
1717

@@ -135,7 +135,7 @@ def test_publishing_message_metadata_using_models(self):
135135
self.assertIsNotNone(scheduled.get("message").get("metadata"))
136136

137137
def test_publishing_entity_metadata(self):
138-
client: WebClient = WebClient(token=self.bot_token,base_url='https://dev.slack.com/api/')
138+
client: WebClient = WebClient(token=self.bot_token)
139139
new_message = client.chat_postMessage(
140140
channel="C014KLZN9M0",
141141
text="Message with entity metadata",
@@ -238,14 +238,14 @@ def test_publishing_entity_metadata_using_models(self):
238238
custom_fields=custom_fields
239239
)
240240

241-
client: WebClient = WebClient(token=self.bot_token,base_url='https://dev.slack.com/api/')
241+
client: WebClient = WebClient(token=self.bot_token)
242242
new_message = client.chat_postMessage(
243243
channel="C014KLZN9M0",
244244
text="Message with entity metadata",
245245
metadata=EventAndEntityMetadata(
246246
entities=[
247247
EntityMetadata(
248-
entity_type=EntityType.TASK,
248+
entity_type="slack#/entities/task",
249249
external_ref=ExternalRef(id="abc123"),
250250
url="https://myappdomain.com",
251251
entity_payload=entity,

‎slack_sdk/models/basic_objects.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def validate_json(self) -> None:
4040
if callable(method) and hasattr(method, "validator"):
4141
method()
4242

43-
def get_attribute(self: object, key: str):
43+
def get_object_attribute(self, key: str):
4444
return getattr(self, key, None)
4545

4646
def get_non_null_attributes(self) -> dict:
@@ -60,7 +60,7 @@ def to_dict_compatible(value: Union[dict, list, object, tuple]) -> Union[dict, l
6060
return value
6161

6262
def is_not_empty(self, key: str) -> bool:
63-
value = self.get_attribute(self, key)
63+
value = self.get_object_attribute(key)
6464
if value is None:
6565
return False
6666

@@ -78,7 +78,7 @@ def is_not_empty(self, key: str) -> bool:
7878
return value is not None
7979

8080
return {
81-
key: to_dict_compatible(value=self.get_attribute(self, key))
81+
key: to_dict_compatible(value=self.get_object_attribute(key))
8282
for key in sorted(self.attributes)
8383
if is_not_empty(self, key)
8484
}

‎slack_sdk/models/metadata/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ def entity_attributes(self, value: Union[Dict[str, Any], EntityAttributes]):
11121112
"""Set the entity attributes data."""
11131113
self._entity_attributes = value
11141114

1115-
def get_attribute(self: object, key: str):
1115+
def get_object_attribute(self, key: str):
11161116
if key == "attributes":
11171117
return self._entity_attributes
11181118
else:

0 commit comments

Comments
 (0)