fix(oauth): treat naive datetime values as UTC when converting to timestamps

Author: kwy404

slack_sdk/oauth/installation_store/internals.py

@@ -1,4 +1,4 @@
-from datetime import datetime
+from datetime import datetime, timezone
 from typing import Type, TypeVar, Union
 
 
@@ -28,6 +28,9 @@ def _timestamp_to_type(ts: Union[TimestampType, datetime, str], target_type: Typ
         # see https://github.com/google/pytype/issues/1012
 
     elif isinstance(ts, datetime):
+        if ts.tzinfo is None:
+            # naive datetime values (e.g., loaded from a database) are stored in UTC
+            ts = ts.replace(tzinfo=timezone.utc)
         result = target_type(ts.timestamp())
     elif isinstance(ts, str):
         try:

tests/slack_sdk/oauth/installation_store/test_internals.py

@@ -25,6 +25,7 @@ def test_iso_format(self):
     [
         (1701209097, int, 1701209097),
         (datetime(2023, 11, 28, 22, 9, 7, tzinfo=timezone.utc), int, 1701209347),
+        (datetime(2023, 11, 28, 22, 9, 7), int, 1701209347),
         ("1701209605", int, 1701209605),
         ("2023-11-28 22:11:19", int, 1701209479),
         (1701209998.3429494, float, 1701209998.3429494),