Skip to content

chore: drop setup.cfg and configure metadata in pyproject.toml only #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 1 commit into from
Nov 6, 2026
Merged

chore: drop setup.cfg and configure metadata in pyproject.toml only #2015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ build-backend = "setuptools.build_meta"

[project]
name = "slack_sdk"
dynamic = ["version", "readme", "authors", "optional-dependencies"]
dynamic = ["version", "readme", "optional-dependencies"]
description = "The Slack API Platform SDK for Python"
license = { text = "MIT" }

@srtaalej srtaalej Nov 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR: setuptools warns that the table form of license is deprecated (and so is the license classifier). Moving to license = "MIT" needs setuptools>=77, which doesn't work with our Python 3.7 support, so maybe that's a follow-up once we drop older Pythons.

authors = [{ name = "Slack Technologies, LLC" }, { email = "opensource@slack.com" }]

@srtaalej srtaalej Nov 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, splitting name and email into separate entries is what keeps Author: and Author-email: as two fields. A combined { name, email } entry would emit only Author-email: "Slack Technologies, LLC" <opensource@slack.com> and change the pip show output.

requires-python = ">=3.7"
keywords = [
"slack",
Expand Down Expand Up @@ -42,6 +43,7 @@ classifiers = [


[project.urls]
Homepage = "https://github.com/slackapi/python-slack-sdk"

@srtaalej srtaalej Nov 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this shows up as Project-URL: Homepage, ... in METADATA instead of the old Home-page: header. pip 24.1+ maps it back to Home-page in pip show, while pip 24.0 shows it empty, matching the caveat in the description. Seems fine to me.

Documentation = "https://docs.slack.dev/tools/python-slack-sdk/"
Source = "https://github.com/slackapi/python-slack-sdk"

Expand Down
5 changes: 0 additions & 5 deletions setup.cfg
View file
Open in desktop

This file was deleted.

Loading