Repository navigation
test: add unit tests for NewCLIDependency in internal/update - #783
Merged
Merged
Conversation
mwbrooks
added
code health
zimeg
approved these changes
Nov 13, 2026
zimeg
left a comment
zimeg
left a comment
Member
There was a problem hiding this comment.
✅ LGTM! Thanks for closing this coverage gap.
Member
Author
|
Thanks @zimeg for the quick review! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - adds tests only, with no user-facing changes.
Summary
This pull request adds unit tests for
NewCLIDependencyininternal/update/cli.go, which had no test coverage. It is one in a series of small coverage PRs.Test_NewCLIDependencytointernal/update/cli_test.gowith cases that check the clients and version are stored and no release is set yetinternal/updatecoverage from 48.3% to 48.8%Testing
go test ./internal/update/... -run Test_NewCLIDependency -vand confirm the cases passRequirements