Repository navigation
refactor: use slices.Backward in internal/manifest/validate.go - #784
Merged
Merged
Conversation
Member
Author
|
Thanks @zimeg for the quick review! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal cleanup with no user-facing changes.
Summary
This pull request replaces a reverse index loop with
slices.Backwardininternal/manifest/validate.gofor maintainers, from the Go modernize analyzer. Same behaviour, in the form current Go recommends.range slices.Backward(slackError.Details)inHandleConnectorApprovalRequiredinstead of counting down fromlen(slackError.Details) - 1, and still deletes in placeTesting
go run golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest ./...and confirminternal/manifest/validate.gono longer reportsslices.Backwardgo build ./... && go test ./...Requirements