Repository navigation
ci: attach only versioned archives to production GitHub releases - #786
Merged
Merged
Conversation
The dev and latest archives still upload to S3 for the install scripts and dev builds, and stay on dev-build and feature prereleases. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Member
Author
|
📦 Thanks for the kind review @cchensh! The next stable release should list just the 11 versioned archives. |
Member
|
@zimeg one follow-up after merge: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A, this changes release automation only.
Summary
This pull request attaches only the versioned archives to production GitHub releases, so the
slack_cli_dev_*andslack_cli_latest_*copies stop showing up on stable releases.scripts/archive.shcopies each versioned archive to_devand_latestnames for the install scripts. Thecreate-github-release-and-artifactsjob then uploaded everyslack_*file in the artifacts directory to the release.productionis true, the upload loop now skipsslack_cli_dev_*andslack_cli_latest_*. Nothing else changes.s3-uploadjobs attach is still persisted unfiltered, so downloads.slack-edge.com (the installers andslack upgrade) gets the same files as before.dev-buildand-featureprereleases run withproduction: falseand keep every archive.Before, v4.14.0 had 25 assets: 11
slack_cli_4.14.0_*, 7slack_cli_dev_*and 7slack_cli_latest_*.After, a production release has 11 assets:
Testing
The upload step needs the release token and a tagged pipeline, so I couldn't do a full dry run. Instead:
install*.shandrelease_ref, in a temp directory. Then ran bothfindbranches against it:production=trueselected the 11 versioned files above, andproduction=falseselected all 25.slack_cli_*.tar.gz,slack_cli_dev_*.tar.gz,slack_cli_*_windows_64-bit.zip, …) read from the attached workspace and not from the release, so their inputs don't change.scripts/install*.shandinternal/updatedownload from downloads.slack-edge.com, not from GitHub release assets.dev-buildshould still list all 25.Notes
Requirements
🤖 Generated with Claude Code