Skip to content

ci: surface release notification errors for safe retries - #788

Merged
zimeg merged 1 commit into
mainfrom
notify-errors
Nov 14, 2026
Merged

zimeg merged 1 commit into
mainfrom
notify-errors

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

Changelog

No user-facing changes.

Summary

This pull request sets errors: true on the Slack release announcement in the notify job, so a rejected post (e.g. a revoked webhook) fails the job instead of only logging.

  • notify is already its own job, so a red X there leaves the release green and signals gh run rerun <id> --failed. Nothing else changes.
  • Same change as the split notify jobs in bolt-js, node-slack-sdk, slack-github-action and slack-skills-plugin. Motivated by this suggestion on the python release-notify PRs.
  • zizmor .github/workflows/release.yml reports the same two findings as main (github-app at line 25, cache-poisoning at line 39), both outside the notify job.

Testing

After merge, the next release run should show notify posting the announcement. A failed post now marks notify red.

Requirements

Set errors: true on the Slack release announcement so a rejected post fails the notify job instead of only logging, which signals a retry with gh run rerun --failed.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:22
@zimeg zimeg added this to the Next Release milestone Nov 13, 2026
@zimeg zimeg added the build M-T: Changes to compilation and CI processes label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! A red notify job makes a missed CLI release announcement easy to spot and rerun.

@zimeg

zimeg commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

📣 Thanks for the kind review @mwbrooks! A missed announcement will finally show up as a red job to rerun.

@zimeg
zimeg merged commit 0b9f723 into main Nov 14, 2026
13 checks passed
@zimeg
zimeg deleted the notify-errors branch November 14, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants