Repository navigation
ci: surface release notification errors for safe retries - #788
Merged
Merged
Conversation
Set errors: true on the Slack release announcement so a rejected post fails the notify job instead of only logging, which signals a retry with gh run rerun --failed. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
2 of 3 tasks
Member
Author
|
📣 Thanks for the kind review @mwbrooks! A missed announcement will finally show up as a red job to rerun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
No user-facing changes.
Summary
This pull request sets
errors: trueon the Slack release announcement in thenotifyjob, so a rejected post (e.g. a revoked webhook) fails the job instead of only logging.notifyis already its own job, so a red X there leaves the release green and signalsgh run rerun <id> --failed. Nothing else changes.notifyjobs in bolt-js, node-slack-sdk, slack-github-action and slack-skills-plugin. Motivated by this suggestion on the python release-notify PRs.zizmor .github/workflows/release.ymlreports the same two findings asmain(github-appat line 25,cache-poisoningat line 39), both outside thenotifyjob.Testing
After merge, the next release run should show
notifyposting the announcement. A failed post now marksnotifyred.Requirements