Skip to content

ci: fail the notify job when the announcement is rejected - #789

Open
zimeg wants to merge 1 commit into
mainfrom
notify-errors-true
Open

zimeg wants to merge 1 commit into
mainfrom
notify-errors-true

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

Changelog

N/A, this changes release automation only.

Summary

This pull request sets errors: true on the release announcement step, so a webhook that rejects the post fails the notify job instead of logging an error and staying green.

         uses: slackapi/slack-github-action@dcb1066f776dd043e64d0e8ba94ca15cc7e1875d # v4.0.0
         with:
+          errors: true
           webhook: ${{ secrets.SLACK_RELEASE_ANNOUNCEMENTS_WEBHOOK_URL }}

Testing

  • On the next release, confirm the announcement posts and the notify job stays green.

Notes

zizmor reports two high findings in release.yml (cache-poisoning, github-app). Both are already on main in other jobs, and this change doesn't touch them.

Requirements

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:58
@zimeg zimeg added this to the Next Release milestone Nov 13, 2026
@zimeg zimeg added the build M-T: Changes to compilation and CI processes label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! A revoked webhook now turns the notify job red instead of passing quietly. Heads up that #788 has the same change, so one of them can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants