Skip to content

fix: suggest an interactive terminal before a flag for hidden input prompts - #790

Open
mwbrooks wants to merge 1 commit into
mainfrom
mwbrooks-password-prompt-hidden-input-hint
Open

mwbrooks wants to merge 1 commit into
mainfrom
mwbrooks-password-prompt-hidden-input-hint

Conversation

@mwbrooks

@mwbrooks mwbrooks commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Changelog

When a command that asks for a secret, such as slack env set, runs without an interactive terminal, the error now suggests running it in a terminal to enter the value with hidden input, before mentioning the flag.

Summary

This pull request changes the suggestion shown when a hidden input prompt can't be shown, for developers and the coding agents running commands for them. Before, the error said to re-run with the value as a flag (--value, --token), which leaves a secret in shell history. A coding agent reading that error would retry with the secret on the command line, and in its transcript.

Suggestion
   Run this command in an interactive terminal to enter the value with hidden input
   The `--value` flag also works, but can leave the value in shell history

The flag still works for scripts and CI. Every other prompt keeps the existing suggestion. This covers the three hidden input prompts: env set, auth revoke, and external-auth add-secret.

Testing

  • Ran slack env set OPENAI_API_KEY < /dev/null in a Bolt project and confirmed the new suggestion above.
  • Ran slack env set OPENAI_API_KEY in a terminal and confirmed the hidden prompt is unchanged.

Notes

Requirements

…rompts

When a hidden input prompt such as `env set` runs without a TTY, the
error suggested passing the value with a flag. For a secret that puts it
in shell history, and a coding agent reading the error would retry with
the secret on the command line. The suggestion now points to an
interactive terminal first and names the flag as the fallback.
@mwbrooks mwbrooks added this to the Next Release milestone Nov 15, 2026
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented security Use on pull requests related to security semver:patch Use on pull requests to describe the release version increment labels Nov 15, 2026
@mwbrooks mwbrooks self-assigned this Nov 15, 2026
@mwbrooks
mwbrooks marked this pull request as ready for review November 15, 2026 04:15
@mwbrooks
mwbrooks requested a review from a team as a code owner November 15, 2026 04:15
@mwbrooks
mwbrooks requested a review from zimeg November 15, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented security Use on pull requests related to security semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant