Skip to content

Commit 9cf7fc0

Browse files
committed
Change icon for right-side menu in repository list screen
This action includes both sort order and filter settings so the filter icon shouldn't be used here. Horizontal overflow is a much better fit.
1 parent a2ffdd2 commit 9cf7fc0

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,18 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<menu xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:app="http://schemas.android.com/apk/res-auto">
4+
45
<item
56
android:id="@+id/search"
67
android:icon="@drawable/action_search"
78
android:title="@string/search"
8-
app:showAsAction="always|collapseActionView"
9-
app:actionViewClass="android.support.v7.widget.SearchView" />
9+
app:actionViewClass="android.support.v7.widget.SearchView"
10+
app:showAsAction="always|collapseActionView" />
11+
1012
<item
1113
android:id="@+id/filter"
12-
android:icon="@drawable/filter"
13-
android:title="@string/issue_filter"
14+
android:icon="@drawable/overflow_horizontal"
15+
android:title="@string/filter_and_sort"
1416
app:showAsAction="ifRoom" />
17+
1518
</menu>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@
165165
<string name="repo_sort_order_creation_asc">Oldest</string>
166166
<string name="repo_sort_order_pushed_desc">Most recently pushed</string>
167167
<string name="repo_sort_order_pushed_asc">Least recently pushed</string>
168+
<string name="filter_and_sort">Filter and Sort</string>
168169

169170
<string name="no_blogs_found">No blogs found.</string>
170171
<string name="no_comments_found">Nobody has commented so far.</string>

0 commit comments

Comments
 (0)