Fix #1390: preserve line breaks and whitespace in FileSystemConfigSource - #1521
Closed
phateffect wants to merge 3 commits into
Closed
Fix #1390: preserve line breaks and whitespace in FileSystemConfigSource#1521phateffect wants to merge 3 commits into
phateffect wants to merge 3 commits into
Conversation
Replace Files.lines().collect(joining()) with Files.readString() to preserve line breaks and whitespace in file-based config values. Add test coverage for multiline file contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, FileSystemConfigSource uses
Files.lines().collect(joining())which strips all line endings from the source file.This PR switches to
Files.readString()to ensure the content is returned exactly as-is, preserving multiline values and trailing spaces.