Stop / Resume reading from Broker - #3378
Open
dometec wants to merge 5 commits into
Open
Conversation
This was referenced Apr 20, 2026
dometec
marked this pull request as ready for review
April 28, 2026 23:02
dometec
marked this pull request as draft
April 28, 2026 23:03
Contributor
Author
|
I tested this feature with some private application module and it works well. I'll switch this PR in ready on the first release of verts-mqtt. |
This was referenced May 5, 2026
dometec
force-pushed
the
stop_resume_reading
branch
from
June 27, 2026 15:40
b5bed84 to
b0c2f72
Compare
dometec
force-pushed
the
stop_resume_reading
branch
from
July 6, 2026 15:38
b0c2f72 to
7926481
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3378 +/- ##
============================================
+ Coverage 77.47% 77.86% +0.38%
- Complexity 3778 5607 +1829
============================================
Files 306 484 +178
Lines 12673 18768 +6095
Branches 1648 2312 +664
============================================
+ Hits 9818 14613 +4795
- Misses 2116 3014 +898
- Partials 739 1141 +402
🚀 New features to boost your workflow:
|
dometec
marked this pull request as ready for review
July 6, 2026 16:03
Guard the buffer-driven pause() and resume() calls in ClientHolder with isConnected(). Acting on a disconnected session is a no-op, and the paused state could otherwise leak across a reconnect, leaving consumption stuck.
dometec
force-pushed
the
stop_resume_reading
branch
from
July 14, 2026 16:48
7926481 to
f7d214e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Draft PR since use vertx-mqtt compiled with vert-x3/vertx-mqtt#267 and vert-x3/vertx-mqtt#268 not released yet.
The first commit add a test to show the error where the application message buffer is full.
In the second commit I've added the logic to stop and restart the socket read when the buffer is going to be almost full.
Added also some documentation in receiving-mqtt-messages.md, I hope that clear the problem and the parameters usage.
The attirbutes "receive-buffer-size", "recv-bytebuf-allocator-size" have direction = INCOMING_AND_OUTGOING becouse are used by the mqtt client that can be common between incoming and outgoing channel.