Skip to content

Commit 8702bd6

Browse files
authored
ci(pr-build): give go test a 20m package timeout (#1735)
## Description The Build Binaries job in `pr-build.yml` runs `go test ./...` with Go's default 10-minute per-package timeout. `internal/server` now takes close to that on a loaded runner, so the job failed on PR #1718 (run 39776808883) with `panic: test timed out after 10m0s` while every test was passing; the test running at that moment had been going for 10 seconds. The same job passed on the previous head of that PR and on the run in between, so this is a budget, not a hang. Set `-timeout 20m` on both `go test` lines, matching what `unit-tests.yml` already uses. CI-only change.
1 parent fa75d60 commit 8702bd6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎.github/workflows/pr-build.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,9 @@ jobs:
219219
run: |
220220
# On Windows, skip internal/server tests (E2E tests timeout after 11 minutes)
221221
if [ "${{ matrix.goos }}" = "windows" ]; then
222-
go test -tags nogui -v -skip "E2E|Binary|MCPProtocol" $(go list ./... | grep -v 'internal/server$')
222+
go test -tags nogui -v -timeout 20m -skip "E2E|Binary|MCPProtocol" $(go list ./... | grep -v 'internal/server$')
223223
else
224-
go test -tags nogui -v -skip "E2E|Binary|MCPProtocol" ./...
224+
go test -tags nogui -v -timeout 20m -skip "E2E|Binary|MCPProtocol" ./...
225225
fi
226226
env:
227227
TIKTOKEN_CACHE_DIR: ${{ runner.temp }}/tiktoken

0 commit comments

Comments
 (0)