Repository navigation
Commit 8acb506
fix(ci): stop the Windows recovered-panic heap crash and the Pass-2 temp-dir race (#1288)
* fix(httpapi): stop the recovered nil-config panic in add-from-registry
A controller that reports success without a server config (the test
doubles do) was dereferenced in handleAddFromRegistry; chi's recoverer
turned the fault into a bare 500. Under Go 1.26 on windows/amd64 the
recovered hardware exception corrupts the Go heap (golang/go#81238), so
the internal/httpapi test binary died later with "found pointer to free
object" / "unexpected fault address" on unrelated PRs (#1282, #1285).
Return a JSON 500 instead, the way redactedRegistrySummary already
tolerates a nil entry, and pin it with a test.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* test(scanner): wait for the Pass-2 job before tearing down temp dirs
TestServiceStartScanDeepOnRunsSourceResolutionAndPass2 failed on ubuntu
CI with "TempDir RemoveAll cleanup: directory not empty": the Pass-2
goroutine writes tools.json into the server working dir after
ResolveFullSource returns and before it registers its engine job, so an
idle engine can mean "Pass 1 cleared, Pass 2 not started yet" and the
test's teardown raced the write. Wait for the Pass-2 job to reach a
terminal status in storage (its last write on every exit path) first.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent b1777e8 commit 8acb506
3 files changed
Lines changed: 56 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5836 | 5836 | | |
5837 | 5837 | | |
5838 | 5838 | | |
| 5839 | + | |
| 5840 | + | |
| 5841 | + | |
| 5842 | + | |
| 5843 | + | |
| 5844 | + | |
| 5845 | + | |
| 5846 | + | |
| 5847 | + | |
| 5848 | + | |
| 5849 | + | |
5839 | 5850 | | |
5840 | 5851 | | |
5841 | 5852 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2505 | 2505 | | |
2506 | 2506 | | |
2507 | 2507 | | |
2508 | | - | |
2509 | | - | |
| 2508 | + | |
| 2509 | + | |
| 2510 | + | |
| 2511 | + | |
| 2512 | + | |
| 2513 | + | |
| 2514 | + | |
| 2515 | + | |
| 2516 | + | |
2510 | 2517 | | |
2511 | 2518 | | |
2512 | 2519 | | |
| 2520 | + | |
| 2521 | + | |
| 2522 | + | |
| 2523 | + | |
| 2524 | + | |
| 2525 | + | |
| 2526 | + | |
| 2527 | + | |
| 2528 | + | |
| 2529 | + | |
| 2530 | + | |
| 2531 | + | |
| 2532 | + | |
| 2533 | + | |
| 2534 | + | |
| 2535 | + | |
| 2536 | + | |
| 2537 | + | |
2513 | 2538 | | |
2514 | 2539 | | |
2515 | 2540 | | |
| |||
0 commit comments