You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web UI: three presentation defects found re-verifying the UX audit (contradictory card states, raw enum label, stale auth error) #1065
Three Web UI defects found while re-verifying the Web UI UX audit against a live core on main. None is a regression of anything in that audit — they were found during the re-check and are recorded there under "New defects found while re-checking", where they would otherwise be lost. Grouped because all three are small presentation defects in the same sweep; each is independently fixable.
Verified on main @ 4d30624, isolated instance, scratch --config and --data-dir.
1. A server card asserts two contradictory security states at once
The memory card renders a green ✓ Clean scan verdict directly above a yellow ⚠ Quarantined — needs security review banner.
Both are individually true — the last scan found nothing, and the server has not been approved — but stacked together they tell the operator opposite things about whether the server is safe. The scan verdict is about content; quarantine is about review state. The card presents them as one axis.
Suggested fix: subordinate the scan verdict while a server is quarantined (e.g. render it inside the quarantine banner as "last scan: clean — still needs review"), so there is one security headline per card.
2. The Activity Type column mixes two vocabularies
On one screen, in one column:
Rendered
Style
Quarantine Change
humanised
Policy Decision
humanised
Internal Tool Call
humanised
tool_quarantine_change
raw snake_case
The raw value leaks the storage enum straight into the table. Every other row in the same column is title-cased prose.
Suggested fix: add the missing label mapping for tool_quarantine_change (and audit the enum for any other unmapped member — a mapping keyed by known values will silently pass through anything it does not recognise, which is how this one got out).
3. A stale auth error survives a successful sign-in
With no stored API key, /ui/activity shows three auth surfaces at once: the Authentication Required modal, an inline red Invalid or missing API key / Retry panel behind it, and a Disconnected chip in the header.
Entering a valid key and pressing Set Key re-authenticates the header — server counts, tool count and the Live badge all come back — but the view body keeps the red panel and renders zero rows until the user clicks Retry by hand.
So the app knows it is authenticated and still shows the failure that is no longer true.
Suggested fix: have the successful key-set invalidate and refetch the view's data rather than leaving the previous error state in place.
(The related half of audit finding F28 — the field calling the key "optional" — is genuinely fixed; it now reads API key (required). This is the part that is not.)
Contradictory card states — while a server is quarantined the standalone scan-verdict badge is suppressed and the verdict is folded into the quarantine banner as a subordinate clause (Last scan: clean — still needs review), so the card carries exactly one security headline. Same subordination ServerDetail's spec-088 banner already does. Every verdict still ends in a request to review — including failed, which is an incomplete scan, never a threat verdict.
Raw enum in the Activity Type column — four backend types had no label, not one: tool_quarantine_change, security_scan (already rendering raw in shipped UI since it gained a findings drawer in docs(qa): Web UI UX audit — ranked findings (ux-audit epic) #1046), credential_broker and prompt_get. The map is completed and exported, and the || type passthrough is replaced with a snake_case → Title Case fallback so an unmapped value can never leak raw again. The filter dropdown is now derived from the same map rather than hand-copied (it was three types short).
Per the issue's suggestion to stop this recurring, the guard lives in Go, not vitest: internal/storage/activity_label_parity_test.go fails when a backend type has no Web-UI label. .github/workflows/frontend.yml is path-filtered to frontend/**, so a vitest-only guard would never run on the Go-only change that adds a type. A second test asserts ValidActivityTypes covers every declared constant so the first cannot go vacuously green.
Stale auth error after sign-in — a monotonic authEpoch in the system store, bumped only on a genuine failed→ok transition, keys <router-view> so a repaired auth remounts the current view and its error/loading/data reset. AuthErrorModal's "Refresh & Retry" now validates the reloaded key before reporting success; it previously cleared the auth flag without verifying anything, which is why the stale panel survived on that path too.
Verified in a live Web UI against an isolated core: no bare "Clean" anywhere on the Servers page, the Type column renders Tool Quarantine Change / Security Scan, and signing in drops the red panel and renders rows with no manual Retry.
Activity
fix: quarantined servers over-report available tools (#1064) + three …
Dumbris commentedon Aug 27, 2026
All three defects fixed in #1072 (merged).
Contradictory card states — while a server is quarantined the standalone scan-verdict badge is suppressed and the verdict is folded into the quarantine banner as a subordinate clause (
Last scan: clean — still needs review), so the card carries exactly one security headline. Same subordinationServerDetail's spec-088 banner already does. Every verdict still ends in a request to review — includingfailed, which is an incomplete scan, never a threat verdict.Raw enum in the Activity Type column — four backend types had no label, not one:
tool_quarantine_change,security_scan(already rendering raw in shipped UI since it gained a findings drawer in docs(qa): Web UI UX audit — ranked findings (ux-audit epic) #1046),credential_brokerandprompt_get. The map is completed and exported, and the|| typepassthrough is replaced with a snake_case → Title Case fallback so an unmapped value can never leak raw again. The filter dropdown is now derived from the same map rather than hand-copied (it was three types short).Per the issue's suggestion to stop this recurring, the guard lives in Go, not vitest:
internal/storage/activity_label_parity_test.gofails when a backend type has no Web-UI label..github/workflows/frontend.ymlis path-filtered tofrontend/**, so a vitest-only guard would never run on the Go-only change that adds a type. A second test assertsValidActivityTypescovers every declared constant so the first cannot go vacuously green.Stale auth error after sign-in — a monotonic
authEpochin the system store, bumped only on a genuine failed→ok transition, keys<router-view>so a repaired auth remounts the current view and its error/loading/data reset.AuthErrorModal's "Refresh & Retry" now validates the reloaded key before reporting success; it previously cleared the auth flag without verifying anything, which is why the stale panel survived on that path too.Verified in a live Web UI against an isolated core: no bare "Clean" anywhere on the Servers page, the Type column renders
Tool Quarantine Change/Security Scan, and signing in drops the red panel and renders rows with no manual Retry.feat(079): "N releases / M weeks behind" upgrade delta (#1081), and f…